Skip to content

chore(docs): update i18n status in CLAUDE.md and AssetConverterConfig comment - #307

Merged
jsboige merged 1 commit into
masterfrom
chore/i18n-status-docs-consolidation
May 18, 2026
Merged

chore(docs): update i18n status in CLAUDE.md and AssetConverterConfig comment#307
jsboige merged 1 commit into
masterfrom
chore/i18n-status-docs-consolidation

Conversation

@jsboige

@jsboige jsboige commented May 18, 2026

Copy link
Copy Markdown
Contributor

Context

Consolidates obsolete documentation findings from cycles 57, 59, 60:

Single PR per jsboige direction ("consolide les docs cycle 57+59+60").

Changes

CLAUDE.md (5 sections updated)

Section Change
Translation Pipeline gpt-4.1 primary → gpt-5.5 primary (PR #302), gpt-4.1/gpt-4.1-mini fallback; Virtues 100% translated (PRs listed)
Prochaines etapes Item 10 (#211 closed), item 12 (Virtues done), item 13 (76/167 missing, not 77) — strike-through completed
Data Quality Issues Scenarii 53%→54%, Virtues resolved (strike-through), PT Rules fix linked to PR #306
Validation Multilingue Note Bug #216 fixed April 2026 + cycle 56 audit reference (Strategy D recommended)
Coherent sections CardPen, GSheet, Mind Maps, Tests, Stable Deps — unchanged (cycle 57+59 audit confirmed coherent)

AssetConverterConfig.cs:132-134

-					// Virtues: CSV currently only has _fr columns (issue #183/#205 upgrade unblocks translation but dataset not yet regenerated).
-					// Mapping is a no-op until the CSV exposes title_en/description_en/... etc.
-					// Template placeholders use {{title_fr}}, {{description_fr}}, {{family_fr}}, {{subfamily_fr}}, {{subsubfamily_fr}}, {{remark_fr}}.
+					// Virtues: CSV has fr/en/ru/pt at 100% coverage on title/description/remark (PRs #218, #236, #246, #290, #295 — April-May 2026).
+					// Template placeholders use {{title_fr}}, {{description_fr}}, {{family_fr}}, {{subfamily_fr}}, {{subsubfamily_fr}}, {{remark_fr}}.
+					// FrontFieldConversions below swap _fr → _en/_ru/_pt at runtime via LocalizationConfig.CardSetLocalizations.

3 lines comment replaced by 3 lines accurate comment.

Verification

Test plan

  • CI build (Debug + Release) — should pass (comment-only change in C#, doc-only in CLAUDE.md)
  • CI tests — should pass (77 tests, no logic touched)
  • No CSV touched, no template touched, no config logic touched

Linked

🤖 Generated with Claude Code

… comment

Consolidates obsolete documentation findings from cycles 57, 59, 60:

CLAUDE.md (5 sections updated):
- Translation Pipeline: gpt-5.5 primary (PR #302), gpt-4.1 fallback, Virtues 100% translated
- Prochaines etapes: items 10 (#211 closed), 12 (Virtues done), 13 (76/167 missing)
- Data Quality Issues: Scenarii 54%, Virtues resolved, PT Rules fix linked to PR #306
- Validation Multilingue: note Bug #216 fixed April 2026 + cycle 56 audit reference
- Sections coherent (CardPen, GSheet, Mind Maps, Tests, Stable Deps): unchanged

AssetConverterConfig.cs:132-134:
- Comment was claiming Virtues CSV is _fr only and mapping is no-op
- Reality: CSV has fr/en/ru/pt 100% coverage since April-May 2026
- Updated to reference actual translation PRs and clarify runtime swap mechanism

No functional change - documentation/comment cleanup only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jsboige
jsboige merged commit c922c66 into master May 18, 2026
3 checks passed
@jsboige
jsboige deleted the chore/i18n-status-docs-consolidation branch June 1, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant