AP_Notify: Rework to allow selecting different devices at runtime take 2

[jmachuca77]

This removes the #defines used at compile time and instead populates the _devices array at runtime based on parameter NTF_BRD_TYPE.
Parameter BRD_TYPE from AP_BoardConfig cannot be used as it is not available on all boards and does not have all boards available.(excluded on Linux Builds)

This is related to issue #5989, and #5986

[magicrub]

please remove commented code

[magicrub]

please remove commented code

[jmachuca77]

I can't delete this code as it is needed for the OreoLEDs to work, but its breaking the px4_v2 compile so I need a little feedback from Tridge or Randy as to how to handle this.

[OXINARF]

I haven't yet reviewed this properly but some points:

• I see no reason to use a separate board enum when we have one already in BoardConfig; the fact there is no Linux boards there is for a good reason, they are differentiated at compile time, not runtime. Also, we don't really need a parameter for different boards, just a parameter for using Solo tones or not
• ToneAlarm_PX4_Solo is almost certainly not up-to-par with ToneAlarm_PX4; in fact they should be merged and the tones to be used chosen based on the parameter
• There is no need to store 5 pointers to different notify devices, they are already stored in the _devices variable

[jmachuca77]

ToneAlarm does seem like it can be merged, so I can work on that, I have removed the unnecessary pointers.
I'll have to think about what to do with the parameter.

[OXINARF]

@jmachuca77 For the parameter, just look at what is done in other libraries (the AP_InertialSensor is probably the best one).

[Pedals2Paddles]

I've tested this on the Solo and it's working great, thank you. That said, I agree with @OXINARF that it is probably time to put the multitude of tone alarms together. Operationally, there is no reason the Solo a drastically different set of tones. In fact I don't think it needs anything different at all. I will take a look at them and see what the differences are and if they're necessary.

[Pedals2Paddles]

Would like to discuss this on the 5/15 dev call. Especially if @jmachuca77 is available on the call.

• Minor rework will be needed since AP_Notify: Eliminated need for Solo specific tones, added power off tone to px4 tones #6218 eliminates the need for Solo specific tones all together. This will therefore only change the visual notification devices.
• This PR is really all that's left for ArduCopter to be largely Solo compatible
• This PR makes selecting the notification devices dynamic and expandable for the future, which is great for all vehicles, present and future, not just the Solo

[OXINARF]

Replaced by #6340