Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane/Copter/Rover/Tracker: 4.6.0-beta1 release #28536

Open
wants to merge 40 commits into
base: ArduPilot-4.6
Choose a base branch
from

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Nov 6, 2024

This is the Copter, Rover, Tracker, Plane 4.6.0-beta1 release

To create the release notes I did this:

  1. used Github to compile a full list of PRs in the ArduPilot-4.6 branch vs the Copter-4.5 branch. The output from that can be found in this spreadsheet
  2. sorted the PRs by subsystem
  3. manually reviewed each PR's title (and sometimes the content) in order to come up with a description of the change

Any and all feedback is greatly appreciated. In particular I'd like to hear about:

a. changes that should be added or removed from the ReleaseNotes
b. corrections to change descriptions. If possible please provide a copy-paste-able rewording
c. suggestions on re-ordering or moving changes within the ReleaseNotes

I haven't included Blimp or Sub but we could if maintainers of those vehicles would like (FYI @MichelleRos, @Williangalvani)

Copy link
Collaborator

@Ryanf55 Ryanf55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see these put together!

ArduCopter/ReleaseNotes.txt Show resolved Hide resolved
Copy link
Contributor

@tpwrules tpwrules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much, great to see the list so big!

Added some wording nits for some stuff I've worked on.

AntennaTracker/ReleaseNotes.txt Show resolved Hide resolved
AntennaTracker/ReleaseNotes.txt Outdated Show resolved Hide resolved
AntennaTracker/ReleaseNotes.txt Outdated Show resolved Hide resolved
AntennaTracker/ReleaseNotes.txt Outdated Show resolved Hide resolved
AntennaTracker/ReleaseNotes.txt Outdated Show resolved Hide resolved
AntennaTracker/ReleaseNotes.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@bnsgeyer bnsgeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have one change.
otherwise it looks good to me.

ArduCopter/ReleaseNotes.txt Outdated Show resolved Hide resolved
@rmackay9 rmackay9 dismissed bnsgeyer’s stale review November 10, 2024 23:30

BillG's changes added

peterbarker and others added 25 commits November 12, 2024 10:25
uses a macro to generate a value, which makes it problematic from a matching sense
Makes it easier for GUI applications to display this better and valudate the range
In file included from ../../libraries/AP_CheckFirmware/AP_CheckFirmware.cpp:13:
../../libraries/AP_CheckFirmware/../../Tools/AP_Bootloader/support.h:57:25: error: "CH_CFG_USE_HEAP" is not defined, evaluates to 0 [-Werror=undef]
   57 | #if defined(STM32H7) && CH_CFG_USE_HEAP
      |                         ^~~~~~~~~~~~~~~
compilation terminated due to -Wfatal-errors.
cc1plus: all warnings being treated as errors
Add the missing byte swapping for 16bit values
* And switch to mavlink_coordinate_frame_to_location_alt_frame

Signed-off-by: Ryan Friedman <[email protected]>
Parameters are being generated as `INS_` as the group, so `INS_USE` is actually documented as `INS__USE` (not the double underscore).
Without this, parameter names are generated as eg. 'BATT2__ARM_VOLT'
allows lua to retrieve vendor specific data from CAN nodes
Co-authored-by: Bill Geyer <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Co-authored-by: Bill Geyer <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Co-authored-by: Bill Geyer <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Co-authored-by: Bill Geyer <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Thomas Watson <[email protected]>
Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really well done on the release notes, just found some minor issues

- DroneCAN DNA server fixes including removing use of invalid node IDs, faster ID allocation, elimination of rare inability to save info
- DroneCAN EFI health check fix
- DroneCAN ESC battery monitors calculate consumed mah
- DroneCAN ESCs and servos forced to zero when disarmed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only ESCs, servos work when disarmed

- DroneCAN EFI health check fix
- DroneCAN ESC battery monitors calculate consumed mah
- DroneCAN ESCs and servos forced to zero when disarmed
- DroneCAN fix for deadlock and saturation of CAN bus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is in 4.5.7

- MLX90614 temperature sensor support
- MSP GPS ground course scaling fixed
- MSP RC uses scaled RC inputs (fixes issue with RCx_REVERSED having no effect)
- NanoRadar MR72 CAN radar support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was in 4.5.0


4) Networking enhancements and fixes

- Allow multiple UDP clients to connect/disconnect/reconnect
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate from above


- Harmonic notch filter freq clamping and disabling reworked
- Harmonic notch handles negative ESC RPMs
- Harmonic notch supports per-motor throttle-based harmonic notch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most important is harmonic notch is active in forward flight on quadplanes

- Takeoff fixes for fence autoenable
- Takeoff improvements including less overshoot of TKOFF_ALT
- TECS reset along with other controllers (important if plane dropped from balloon)
- Throttle passthrough support while in VTOL modes removed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is an internal code re-arrangement not a user visible change

- BATTERY2 message deprecated (replaced by BATTERY_STATUS)
- CMD_MISSION_START/STOP rejected if first-item/last-item args provided
- Deny attempts to upload two missions simultaneously
- ESC telemetry works even when less than 4 ESCs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm sure we support less than 4 ESCs already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.