[Forwardport] Admin controller product set save refactor#1
Closed
AnshuMishra17 wants to merge 2997 commits into2.3-developfrom
Closed
[Forwardport] Admin controller product set save refactor#1AnshuMishra17 wants to merge 2997 commits into2.3-developfrom
AnshuMishra17 wants to merge 2997 commits into2.3-developfrom
Conversation
…rm due to space and font-size magento#16097
- Merge Pull Request magento#16225 from tejash-wagento/magento2:2.3-develop-PR-port-16082 - Merged commits: 1. 849d23d
Accepted Public Pull Requests: - magento#16135: Fix type hints and add undefined property in Webapi [2.3-develop] (by @mhauri) - magento#16170: 1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism. (by @nmalevanec) - magento#16153: 1190: CreateOrderBackendPartOneTest rework to support MSI reservation mechanism. (by @nmalevanec) - magento#16061: Change the favicon file to the newer Magento logo (by @DMMundle) - magento#16155: [Forwardport] chore: prefer woff and woff2 (by @DanielRuf) - magento#15777: [Forwardport] Fix negative basket total due to shipping tax residue (by @osrecio) - magento#15861: [Forwardport] ISSUE-14747 Newsletter subscription confirmation message does not dis� (by @rahul-kachhadiya) - magento#16097: [Forwardport] fix: prevent inline-block issue in name form due to space and font-size (by @DanielRuf) - magento#15798: [Forwardport] Removed unnecessary css. magento#2 (by @chirag-wagento) - magento#16038: [Forwardport] bugfix checkout page cart icon color (by @chirag-wagento) - magento#15759: [Forwardport] 2.3 develop pr port 15566 (by @vgelani) - magento#16137: FIX for apparently random API failures while using array types (by @phoenix128) Fixed GitHub Issues: - magento#1163: Problem when change less file in magento. (reported by @zivendesign) has been fixed in magento#16170 by @nmalevanec in 2.3-develop branch Related commits: 1. f53c620 - magento#1190: installation error in 0.74.0-beta4 (reported by @sivajik34) has been fixed in magento#16153 by @nmalevanec in 2.3-develop branch Related commits: 1. 2b8b9d5 - magento#14747: Newsletter subscription confirmation message does not display after clicking link in email (reported by @tohann) has been fixed in magento#15861 by @rahul-kachhadiya in 2.3-develop branch Related commits: 1. 75516bf - magento#16047: inline-block issue in name form (reported by @DanielRuf) has been fixed in magento#16097 by @DanielRuf in 2.3-develop branch Related commits: 1. 204b4ac - magento#15565: Getting wrong frontend-controller, when using storecodes in urls (reported by @EliasKotlyar) has been fixed in magento#15759 by @vgelani in 2.3-develop branch Related commits: 1. 61856f5 2. 4c77dff
…rrection. magento#16224 - Merge Pull Request magento#16224 from saurabh-aureate/magento2:2.3-develop-PR-port-15993 - Merged commits: 1. 57b9cd2 2. bd15eb3 3. 3000eac
…faster than invoking functions in PHP
…8-tech-debt-cleanup-background-attributes-for-banner
…reservation mechanism.
- Rename duplicate element that broke PageBuilder tests
- Add functional test
…0828-tech-debt-cleanup-background-attributes-for-banner [obsessive] MAGETWO-90828: [Tech Debt] Cleanup Background Attributes for Banner
… attribute from product grid - fixed static failure
…erface, remove meaningless code
…status-search # Conflicts: # app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php # app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
…status-search # Conflicts: # app/code/Magento/AsynchronousOperations/Api/Data/OperationSearchResultsInterface.php # app/code/Magento/AsynchronousOperations/Model/OperationRepository.php
…dvanced-attributes
[borg] MAGETWO-86795: Admin Create Customer functional test fails
…e-advanced-attributes
…move-advanced-attributes [obsessive] MC-401: Advanced Attributes Not Removing From Preview
Status Search API
[pangolin] Weekly RE-develop functional tests
AnshuMishra17
pushed a commit
that referenced
this pull request
Jun 30, 2018
Merged with last commits
AnshuMishra17
pushed a commit
that referenced
this pull request
Jul 3, 2018
[Forwardport] When searching for the title if search for all the segments that has …
AnshuMishra17
pushed a commit
that referenced
this pull request
Jul 27, 2018
Fixed a grammatical error on the vault tooltip
AnshuMishra17
pushed a commit
that referenced
this pull request
May 27, 2019
…sh-1 Changed canonical_url to relative_url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#16217
Description
Remove direct use of object manager for admin attribute set save controller using constructor based dependency injection.
Manual testing scenarios
Created a new attribute set in admin under Stores -> Attribute Set -> Add Attribute Set.
Edit an existing attribute set under Stores -> Attribute Set