Fix type hints and add undefined property in Webapi [2.3-develop]#16135
Merged
magento-engcom-team merged 3 commits intomagento:2.3-developfrom Jun 19, 2018
mhauri:fix-in-2.3-develop-webapi
Merged
Fix type hints and add undefined property in Webapi [2.3-develop]#16135magento-engcom-team merged 3 commits intomagento:2.3-developfrom mhauri:fix-in-2.3-develop-webapi
magento-engcom-team merged 3 commits intomagento:2.3-developfrom
mhauri:fix-in-2.3-develop-webapi
Conversation
added 3 commits
June 14, 2018 15:36
Contributor
|
Hi @mhauri. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 19, 2018
Contributor
|
Hi @mhauri. Thank you for your contribution. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix type hints in
Webapi/Controller/Soap/Request/Handler.phpandWebapi/Model/Plugin/GuestAuthorization.phpFix incorrect case in property annotation in
Soap\Server.phpon line 34add undefined property
_appStateinController\Soap.phpon line 104Fix method
Magento\Webapi\Model\Soap\Fault::toXml()invoked with 1 parameter, 0 required inSoap\FaultTest.phpon line 128Contribution checklist