1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism.#16170
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Jun 19, 2018
nmalevanec:1163
Merged
1163: CreateCreditMemoEntityTest rework to support MSI reservation mechanism.#16170magento-engcom-team merged 1 commit intomagento:2.3-developfrom nmalevanec:1163
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
nmalevanec:1163
Conversation
Contributor
|
Hi @nmalevanec. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 19, 2018
…eservation mechanism. #16170
Contributor
|
Hi @nmalevanec. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add shipment step to CreateCreditMemoEntityTest in order to support MSI reservation mechanism.
Standard magento behaviour - product quantity decreased immediately after place order, but with MSI quantity decreasing only after shipment created, as MSI introduces additional property for product as 'salable quantity'. And after order placement, 'salable quantity' decreasing, not quantity itself(more about reservation mechanism here). Quantity decreasing only after shipment creation. So, in order to pass CreateCreditMemoEntityTest with MSI, additional step with shipment creation should be added into test before assertions.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist