Operations Status Search API Endpoint by anvasiliev · Pull Request #12 · magento/bulk-api-ce

anvasiliev · 2018-04-12T18:33:37Z

Allow to receive all bulk operations by search criteria.

Description

https://github.com/magento-engcom/bulk-api/wiki/Operations-Status-Search-API-Endpoint

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

vrann · 2018-05-09T19:47:10Z

documentation needed: somewhere in API use case section describe why this API is needed. @apaliarush will provide the proper place

nuzil · 2018-05-17T15:59:12Z

PR is ready

…12 - Merge Pull Request magento/graphql-ce#12 from zbigniewkuras/graphql-ce:issiue-3 - Merged commits: 1. dd3aa38 2. 02d6a22 3. 9035d29 4. d804bab 5. 9962c66 6. 1855062

…12

keharper · 2018-05-22T19:47:44Z

@nuzil @vrann Place documentation files under here:

https://github.com/magento/devdocs/tree/develop/guides/v2.3/rest

If you have multiple .md files, create a subdirectory named bulk-api and place the files in there.

paliarush · 2018-05-22T19:50:37Z

+/**
+ * @api
+ */
+interface OperationSearchResultsInterface extends \Magento\Framework\Api\SearchResultsInterface


Please add description to all new classes/interfaces

paliarush · 2018-05-22T19:51:53Z

+interface OperationSearchResultsInterface extends \Magento\Framework\Api\SearchResultsInterface
+{
+    /**
+     * Get attributes list.


attributes list => operations list ?

paliarush · 2018-05-22T20:24:35Z

+        $this->searchResultFactory = $searchResultFactory;
+        $this->joinProcessor = $joinProcessor;
+        $this->operationExtensionFactory = $operationExtension;
+        $this->collectionProcessor = $collectionProcessor ? : ObjectManager::getInstance()


This is a new class, what is the reason to use object manager (it is normally used for backward compatibility)?

paliarush · 2018-05-22T20:24:46Z

+        SearchResultFactory $searchResultFactory,
+        JoinProcessorInterface $joinProcessor,
+        OperationExtensionInterfaceFactory $operationExtension,
+        CollectionProcessorInterface $collectionProcessor = null,


This argument should not be optional.

paliarush · 2018-05-22T20:40:11Z

+            if ($extensionAttributes == null) {
+                $extensionAttributes = $this->operationExtensionFactory->create();
+            }
+            $extensionAttributes->setStartTime('dsadsa');


What does 'dsadsa' mean?

paliarush · 2018-05-22T20:52:57Z

 * @since 100.2.0
 */
-interface OperationInterface
+interface OperationInterface extends \Magento\Framework\Api\ExtensibleDataInterface


In theory, OperationInterface must have getExtensionAttributes and setExtensionAttributes declared.

What is the need to move inheritance from ExtensibleDataInterface up to this interface?

In other case when I call
$this->joinProcessor->process($collection, \Magento\AsynchronousOperations\Api\Data\OperationInterface::class);
in Magento\AsynchronousOperations\Model\OperationRepository::getList()
I get logic exception from Magento\Framework\Api\ExtensionAttributesFactory::getExtensibleInterfaceName($extensibleClassName) because Magento\AsynchronousOperations\Api\Data\OperationInterface and parent interfaces doesn't extend \Magento\Framework\Api\ExtensibleDataInterface

[Backport] #13899 Solve Canada Zip Code pattern

…erface, remove meaningless code

magento-cicd2 · 2018-06-27T09:59:15Z

All committers have signed the CLA.

[Forwardport] Corrected function comment

2.3 develop

Vasiliev.A added 9 commits April 12, 2018 16:07

Api endpoint for search operations by criteria

c72fed2

declare missing strict type

7d4ff3d

filter operations by bulk start_time field

6104730

OperationInterface extends ExtensibleDataInterface

1c4078f

OperationRepositoryInterface getList api-functional test

5536151

add start_time extension attribute to webapi response

1aec471

add misisng new line to config file

8306c69

add misisng strict declaration, fix tests data fixture, fix test

3e7814a

declare strict type for test data fixture

47c99cc

nuzil requested a review from vrann April 27, 2018 08:09

nuzil assigned vrann May 17, 2018

magento-engcom-team pushed a commit that referenced this pull request May 22, 2018

ENGCOM-1635: GraphQL - Added sort by options to Products GraphQL type #…

e1e3fc8

…12

magento-engcom-team pushed a commit that referenced this pull request May 22, 2018

ENGCOM-1635: GraphQL - Added sort by options to Products GraphQL type #…

2a504ce

…12

paliarush suggested changes May 22, 2018

View reviewed changes

magento-engcom-team pushed a commit that referenced this pull request Jun 15, 2018

Merge pull request #12 from hitesh-wagento/2.1-develop-PR-port-13930

fc130fd

[Backport] #13899 Solve Canada Zip Code pattern

vrann added Award: special achievement Award: advanced Award: test coverage labels Jun 26, 2018

vrann added a commit that referenced this pull request Jun 27, 2018

#12: Operations Status Search API Endpoint

a17c1fa

add description for new classed/interfaces, remove not duplicated int…

5d7b3ca

…erface, remove meaningless code

magento-engcom-team merged commit 5d7b3ca into magento:2.3-develop Jun 27, 2018

magento-engcom-team pushed a commit that referenced this pull request Aug 9, 2018

Merge pull request #12 from sanganinamrata/2.3-develop-PR-port-16549

2456027

[Forwardport] Corrected function comment

magento-engcom-team pushed a commit that referenced this pull request Sep 11, 2018

Merge pull request #12 from magento/2.3-develop

92c1aa4

2.3 develop

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Operations Status Search API Endpoint#12

Operations Status Search API Endpoint#12
magento-engcom-team merged 10 commits intomagento:2.3-developfrom
comwrap:async-status-search

anvasiliev commented Apr 12, 2018

Uh oh!

vrann commented May 9, 2018 •

edited

Loading

Uh oh!

nuzil commented May 17, 2018

Uh oh!

keharper commented May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

paliarush May 22, 2018

Uh oh!

anvasiliev Jun 27, 2018 •

edited

Loading

Uh oh!

magento-cicd2 commented Jun 27, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

anvasiliev commented Apr 12, 2018

Description

Contribution checklist

Uh oh!

vrann commented May 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nuzil commented May 17, 2018

Uh oh!

keharper commented May 22, 2018

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

paliarush May 22, 2018

Choose a reason for hiding this comment

Uh oh!

anvasiliev Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magento-cicd2 commented Jun 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vrann commented May 9, 2018 •

edited

Loading

anvasiliev Jun 27, 2018 •

edited

Loading

magento-cicd2 commented Jun 27, 2018 •

edited

Loading