Improve debugging info in ReturnData #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2349 +/- ##
===========================================
+ Coverage 77.75% 78.27% +0.51%
===========================================
Files 324 324
Lines 20820 20825 +5
Branches 1453 1454 +1
===========================================
+ Hits 16188 16300 +112
+ Misses 4629 4522 -107
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was
linked to
issues
Mar 5, 2024
Closed
* Add `ReturnData::t_last` that holds the last solver timepoint (Closes AMICI-dev#2246) * `ReturnData::J` is now the evaluted at `t_last` instead of the last successfully reached output timepoint (Closes AMICI-dev#2334) * `ReturnData::xdot` is now the evaluted at `t_last` instead of the last successfully reached output timepoint
dweindl
force-pushed
the
fix_2246_rdata_tlast
branch
from
1fb5686
to
b9965c4
Compare
FFroehlich
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReturnData::t_lastthat holds the last solver timepoint (Closes In case of simulation failures, store time point of failure in ReturnData #2246)ReturnData::Jis now the evaluted att_lastinstead of the last successfully reached output timepoint (Closes ReturnData::J #2334)ReturnData::xdotis now the evaluted att_lastinstead of the last successfully reached output timepointFor two tests against pre-generated matlab results, the checks for
Jandxdotfail expectedly, since they are now evaluated at a different timepoint.