Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of simulation failures, store time point of failure in ReturnData #2246

Closed
dweindl opened this issue Dec 18, 2023 · 2 comments · Fixed by #2349
Closed

In case of simulation failures, store time point of failure in ReturnData #2246

dweindl opened this issue Dec 18, 2023 · 2 comments · Fixed by #2349
Labels
c++ enhancement

Comments

@dweindl
Copy link
Member

dweindl commented Dec 18, 2023 •
edited
Loading

Makes live easier when trying to analyze failures. Distinguish between fwd and bwd failures.

EDIT: it might be sufficient to make ExpData::t_ public.
@dweindl
Copy link
Member Author

dweindl commented Feb 27, 2024

Also, the corresponding model state would ideally be accessible for debugging.

@dweindl
Copy link
Member Author

dweindl commented Feb 27, 2024

Maybe via storing SimulationState and ModelStateDerived in ReturnData.

@dweindl dweindl mentioned this issue Feb 28, 2024
Closed
dweindl added a commit to dweindl/AMICI that referenced this issue Mar 4, 2024
@dweindl
Add Solver::get_current_time
a59e403 
Prerequisite for AMICI-dev#2246.
@dweindl dweindl mentioned this issue Mar 4, 2024
Closed
dweindl added a commit to dweindl/AMICI that referenced this issue Mar 5, 2024
@dweindl
Improve debugging info in ReturnData
1f25021 
* Add `ReturnData::t_last` that holds the last solver timepoint (Closes AMICI-dev#2246)
* `ReturnData::J` is now the evaluted at `t_last` instead of the last successfully reached output timepoint (Closes AMICI-dev#2334)
* `ReturnData::xdot` is now the evaluted at `t_last` instead of the last successfully reached output timepoint
@dweindl dweindl mentioned this issue Mar 5, 2024
Merged
@dweindl dweindl linked a pull request Mar 5, 2024 that will close this issue
Improve debugging info in ReturnData #2349
Merged
dweindl added a commit to dweindl/AMICI that referenced this issue Mar 6, 2024
@dweindl
Improve debugging info in ReturnData
b9965c4 
* Add `ReturnData::t_last` that holds the last solver timepoint (Closes AMICI-dev#2246)
* `ReturnData::J` is now the evaluted at `t_last` instead of the last successfully reached output timepoint (Closes AMICI-dev#2334)
* `ReturnData::xdot` is now the evaluted at `t_last` instead of the last successfully reached output timepoint
@dweindl dweindl closed this as completed in 8d65524 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c++ enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve debugging info in ReturnData dweindl/AMICI
1 participant
@dweindl