This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Merged
Conversation
Set minimum config for rubocop to show no offenses
* Travis: use jruby-9.1.8.0 * Lint * Travis: jruby-9.1.9.0 * Travis: jruby-9.1.12.0 * Travis: jruby-9.1.13.0
* Rails 5.2 support * Fix Rubocop offences
…drage#102) * Decode sesssion with_indifferent_access if defined ActiveSupport * Decode sesssion with_indifferent_access if defined ActiveSupport
**Why**: The :expire_after config option controls both the Redis session expiration and the expiration of the Rails session cookie. Adding a new config option :ttl allows those controls to be managed separately. The most common case would be if you wanted the Rails cookie to expire when the browser is closed, as it would if :expire_after were set to `nil`.
* Remove the `has_rdoc` flag from the `.gemspec` file. Rubygems has deprecated thios parameter and will be removing it in future versions. SEE: https://blog.rubygems.org/2009/05/04/1.3.3-released.html
We are trying to test our application on rails 6.0.0.alpha but we can't install this because of the version lock Probably this will be helpful that we can try and report any issues with edge rails
* CI matrix: Add 2.6.0, update to jruby-9.2.5.0 * CI: Use 2.6.1, jruby-9.2.6.0 * CI: 2.5.5, 2.6.2 * CI: jruby-9.2.7.0 * CI: Use jruby-9.2.8.0 * RuboCop linting
This fixes following warnings: ``` /home/y-yagi/src/github.com/y-yagi/redis-session-store/.rubocop.yml: Warning: no department given for FileName. /home/y-yagi/src/github.com/y-yagi/redis-session-store/.rubocop.yml: Warning: no department given for DoubleNegation. .rubocop.yml: Metrics/LineLength has the wrong namespace - should be Layout ```
…ge#119) * Update key existence check to use newer #exists? if available - Silences deprecation warning starting in redis gem v4.2 * Add myself to authors * Update CHANGELOG
zachmargolis
requested review from
jmhooper,
kevindayton,
mitchellhenke and
stevegsa
mitchellhenke
approved these changes
Nov 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did:
which should essentially reset our fork to the current top of roidrage/redis-session-store (another option would have been to force push/git reset hard, but I decided this keeps history a little better)
Next step will be to copy this branch: roidrage#125 into this fork