Skip to content

Decode sesssion with_indifferent_access if defined ActiveSupport#102

Merged
Jesterovskiy merged 2 commits intoroidrage:masterfrom
iggant:master
Apr 14, 2018
Merged

Decode sesssion with_indifferent_access if defined ActiveSupport#102
Jesterovskiy merged 2 commits intoroidrage:masterfrom
iggant:master

Conversation

@iggant
Copy link
Contributor

@iggant iggant commented Feb 17, 2018

Inspire by #71

We are moving from active_record_store to redis_session_store

but we already everywhere use key to access session, so we need this fix

@Jesterovskiy
Copy link
Collaborator

#60 @daniel-g @meatballhat I saw this PR and what do you say about @iggant patch? I think this is ok, if someone use ActiveSupport, get with_indifferent_access method. What do you think?

@daniel-g
Copy link

it seems fine on my side, I would just add a text in the documentation about this possibility, maybe a "Rails" section.

@iggant
Copy link
Contributor Author

iggant commented Mar 7, 2018

@Jesterovskiy made rubocop fixes and changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants