Use AbstractSecureStore for security fix#125
Merged
Jesterovskiy merged 2 commits intoroidrage:masterfrom Jan 29, 2022
Merged
Conversation
This allows the store to take advantage of security fix added in rack/rack@cc1d162
|
This addresses this Rack vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2019-16782 |
|
Is there anything holding this up from being merged? 🙂 |
This was referenced Nov 15, 2021
Contributor
|
Hi there! Any news? |
Collaborator
|
Thanks! |
|
I'm not sure that this patch completely addresses the vulnerability described since the gem still uses the session identifier in the cookie as the key in Redis. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the store to take advantage of security fix added in rack/rack@cc1d162