Set minimum config for rubocop to show no offenses#92
Merged
roidrage merged 2 commits intoroidrage:masterfrom Jun 24, 2017
Merged
Set minimum config for rubocop to show no offenses#92roidrage merged 2 commits intoroidrage:masterfrom
roidrage merged 2 commits intoroidrage:masterfrom
Conversation
Jesterovskiy
approved these changes
May 31, 2017
Collaborator
|
@roidrage need your attention =) |
Owner
|
@jpawlyn Thank you for the contribution! It looks like the second commit broke the tests. I don't know RubuCop myself enough to adjust either the code or the configuration. Is that something you could look into so we can get this merged? |
Contributor
Author
|
@roidrage Hi. The commit Set minimum config for rubocop to show no offenses originally broke the tests due to a rubocop issue with version 0.49.1. The second commit is a work around for this bug. Or is there another failure that is occurring not shown above? |
Owner
|
@jpawlyn Apologies, my bad, I looked at them in the wrong order. |
Owner
|
@jpawlyn Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.