Merged
Conversation
#9958) * adding SAML2024 example certs + references, updating tests to use them * changelog: Internal, SAML, adding SAML2024 files/refs (gitlab/identity-devops#4387) * changelog: Internal, SAML, adding SAML2024 files/refs (gitlab/identity-devops#4387)
* Remove 404 action * Remove in_person_residential_address_controller_enabled config flag and uses * Remove address step * Remove step from flow * Remove step_count from in_person address analytics * Add missing ab_test_bucket args to analytics_spec * Remove specs that check marking AddressStep complete/incomplete * Update Address is a link, not a button, and fix address url in specs changelog: Internal, Identity Verification in person, remove FSM Address Step * Remove unused RedoAddressAction and CancelUpdateAddressAction Note that analytics events used by these actions need to be either logged a different way or also deleted. * Remove unused redo and cancel analytics events I checked in the devops repo under terraform/app and no cloudwatch dashboards refer to these events * Update Address is now a link, not a button. Update spec. * fix failing state id spec * remove setting address step * remove addressstep from user_session in cancellations spec * remove unneeded context * changelog: Internal, Address page, delete fsm version of address page * minor updates based on feedback --------- Co-authored-by: svalexander <shannon.alexander-navarro@gsa.gov>
changelog: User Facing Improvements, In-Person Proofing, add error messages behind feature flag for new liveness checks
… a symbol (#9953) * refactor true id response to represent selfie_status with symbols * changelog: Internal, DocAuth, refactor how we represent selfie outcomes * refactor document_capture_session & document_capture_session_result to use selfie_status instead of selfie_success * include selfie_status method in both Mock::ResultResponse and DocAuth::Response * update image uploads controller spec to use selfie_status. Maintain DocAuth::Response usage. * remove selfie_status from DocAuth::Response, keep it in Mock::ResultResponse * fix tests * fix more tests * add selfie_passed? & continue selfie_success to selfie_status refactor * fix failing test * revert doc capture session spec to pre-refactor expectations * ensure that DocCaptureSessionResult will return a symbol for selfie_status * handle 50/50 state in DocCaptureSessionResult * change approach to ensuring that selfie_status returns a symbol * extract selfie_status_from_response method into ApplicationHelper * test selfie_status return type * lint
Bolds non-ruby linter output The output is otherwise very easy to miss. changelog: Internal, Makefile, events ordering linter outputs errors in bold text
* Normalize whitespace in Pii::Attributes values changelog: Bug Fixes, Identity verification, Normalize whitespace in PII * Handle when we set a PII attribute to a non-string Looks like this can sometimes be a Date value, at least initially (roundtripping through JSON serialization turns it into a string). * Remove extraneous '&'
changelog: Internal, Automated Testing, Improve reliability of JavaScript tests
* Remove onbeforeunload logging code changelog: Internal, IdV, remove onbeforeunload logging code * remove spec with event called * remove analytics code * remove unused consts * remove stillonpage timers * remove most prompt-on-navigate calls * remove prompt-on-navigate reverted back to the old way without prompt-on-navigate having it's own package * fix bindPromptOnNavigate in document-capture-polling * re-add bindPromptOnNavigate clean up in spec
Add inline device nickname editing for PIV CAC changelog: User-facing Improvements, MFA, Add inline device editing for PIV CAC
changelog: Internal, Logging, Add reason to admin action output
changelog: Internal, Local Development, Fix Rails server command run in isolation
* build-sass: Bump dependencies * build-sass: Prepare 3.0.0 release changelog: Internal, Build Tools, Publish @18f/identity-build-sass@3.0.0
* normalize-yaml: Enhance to collapse spacing between sentences changelog: User-Facing Improvements, Content, Improve consistency of spacing between content sentences * Normalize YAML * Fix renamed file for package.json * General spacing collapse See: #9980 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
requested review from
bleachbyte,
charleyf,
eileen-nava,
jc-gsa,
kevinsmaster5,
matthinz,
n1zyy,
svalexander,
theabrad and
zachmargolis
matthinz
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal