Skip to content

Fix flakey JavaScript spec for async navigate#9978

Merged
aduth merged 1 commit intomainfrom
aduth-ipp-select-async
Jan 26, 2024
Merged

Fix flakey JavaScript spec for async navigate#9978
aduth merged 1 commit intomainfrom
aduth-ipp-select-async

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Jan 25, 2024

🛠 Summary of changes

Improves reliability of JavaScript tests where a user is navigated after selecting a post office in the in-person proofing flow.

Example failure: https://gitlab.login.gov/lg/identity-idp/-/jobs/985447 (via #9972)

The behavior for redirecting after making a selection occurs only after a network request has finished, which may not be instantaneous.

await request(locationsURL, {
json: selected,
method: 'PUT',
});

📜 Testing Plan

yarn mocha app/javascript/packages/document-capture/components/in-person-location-post-office-search-step.spec.tsx app/javascript/packages/document-capture/components/in-person-location-full-address-entry-post-office-search-step.spec.tsx

changelog: Internal, Automated Testing, Improve reliability of JavaScript tests
@aduth aduth requested a review from matthinz January 25, 2024 21:54
@aduth aduth merged commit 7d0f85d into main Jan 26, 2024
@aduth aduth deleted the aduth-ipp-select-async branch January 26, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants