LG-12047 Remove onbeforeunload logging code#9955
Merged
Conversation
changelog: Internal, IdV, remove onbeforeunload logging code
aduth
reviewed
Jan 22, 2024
Contributor
There was a problem hiding this comment.
Are we also expecting to remove the code which calls the logging?
i.e. most/all of app/javascript/packages/prompt-on-navigate/index.ts
Contributor
Author
yeah. i'll clear that up |
matthinz
reviewed
Jan 24, 2024
|
|
||
| trackEvent(PROMPT_EVENT, { path: window.location.pathname }); | ||
|
|
||
| const stillOnPageIntervalsInSeconds = [...options.stillOnPageIntervalsInSeconds]; |
Contributor
There was a problem hiding this comment.
Can probably remove everything in this function after ev.returnValue = ''; and support for stillOnPageIntervalsInSeconds
Contributor
reverted back to the old way without prompt-on-navigate having it's own package
matthinz
approved these changes
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12047
🛠 Summary of changes
Removed the logging code for the onbeforeunload events. (Popups from document capture or link sent step saying you are going to lose unsaved data).