Merged
Conversation
charleyf
changed the title
dawei-nava
reviewed
Jan 18, 2024
dawei-nava
reviewed
Jan 18, 2024
dawei-nava
reviewed
Jan 18, 2024
…nd feature flag for new liveness checks
…ssages behind feature flag for new liveness checks
dawei-nava
reviewed
Jan 23, 2024
charleyf
commented
Jan 23, 2024
charleyf
commented
Jan 23, 2024
dawei-nava
reviewed
Jan 23, 2024
charleyf
commented
Jan 23, 2024
dawei-nava
reviewed
Jan 24, 2024
| def selfie_live? | ||
| portait_error = get_portrait_error(portrait_match_results) | ||
| return true if portait_error.nil? || portait_error.empty? | ||
| return error_is_not_live(portait_error) |
Contributor
There was a problem hiding this comment.
Nit, redundant return, and there are few methods down there too.
dawei-nava
reviewed
Jan 24, 2024
dawei-nava
reviewed
Jan 24, 2024
dawei-nava
approved these changes
Jan 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://cm-jira.usa.gov/browse/LG-12157
🛠 Summary of changes
This ticket sends selfie errors from the BE to the FE for display to the user. It's required setup work for the FE ticket LG-11893.
To do that it does two things:
errors[]array. This is so we can show different errors if we want to in the future.selfie_liveandselfie_quality_goodthat are sent to the FE. This is so we can show the appropriate text on the review issues step.📜 Testing Plan
I don't have a great testing plan, but checking that the logs show these values being sent to the FE is the core of testing this. For a dev, that would probably mean running
make watch_eventsthen uploading a failing selfie yaml file and looking forselfie_liveandselfie_quality_goodin the logs.