Update documentation and yml files for selfie#425
Merged
night-jellyfish merged 5 commits intomainfrom Jan 11, 2024
Merged
Conversation
12 tasks
charleyf
reviewed
Jan 10, 2024
Co-authored-by: Charley Ferguson <charleyferguson@navapbc.com>
night-jellyfish
commented
Jan 10, 2024
added 2 commits
January 10, 2024 13:58
Need to update the interface here to match a change requested on the IDP PR. Also updating the comment to clarify the difference between the meaning of the values.
Contributor
Author
|
18F/identity-idp#9882 has now been merged so this can be merged when ready. |
charleyf
approved these changes
Jan 11, 2024
Contributor
charleyf
left a comment
charleyf
left a comment
There was a problem hiding this comment.
Text changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change:
sample_full_error.ymlfor selfie entries, with the possible values notatedEven if you put all passing information into the test yaml file it will still produce an error.- you can upload a yml file that passes doc auth)Note: These changes should not be merged until 18F/identity-idp#9882 is merged.