Type/Props Change PR: Send 'toPreviousStep' Down as A Prop#9852
Merged
Type/Props Change PR: Send 'toPreviousStep' Down as A Prop#9852
Conversation
aduth
approved these changes
Jan 4, 2024
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
I hadn't realized this wasn't a proper "step" rendered by FormSteps and instead a subcomponent of the ReviewIssuesStep. I don't have quite as much problem with the original approach with that in mind, though I think it's also fine to have a 1-to-1 with this expecting to receive all of the props that a step receives.
charleyf
commented
Jan 4, 2024
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This is a props change in response to Andrew's comment here. We expect the
toPreviousStepprop to be available to steps even if they're not using it. This PR makes that true, by makingtoPreviousStepavailable to the review step.