Revert changes for LexisNexis InstantVerify AB test#9764
Merged
Conversation
This reverts commit 4000ef5.
…ProofingJob` This commit adds a arg to the `ResolutionProofingJob` which was used in the changes in #9743. That commit was reverted. Old workers did not know about this arg so they raised an ArgumentError when they encountered it. We reverted that change so we could introduce the arg in this one and then revert the revert. [skip changelog]
jmhooper
force-pushed
the
jmhooper-revert-iv-ab-test
branch
from
1af9dbc to
9628e29
Compare
soniaconnolly
approved these changes
Dec 14, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM after talking it through, thanks!
jmhooper
added a commit
that referenced
this pull request
Dec 14, 2023
I reverted 2 changes in #9764 to address a bug in the way the arguments were passed to the ResolutionProofingJob. This commit reverts those 2 reverts to put the A/B test implementation back in place. * Revert "Revert "LG-11671: Lexisnexis Instant Verify workflow A/B test (#9743)"" * Revert "Revert "Capitalization: Rename LexisnexisInstantVerify to LexisNexisInstantVerify (#9763)"" [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we deployed the changes in #9763 and #9743 a new argument was introduced for the resolution proofing job. This argument was not recognized by old hosts performing the job which led to an argument error.
This commit reverts both of those and adds a commit to introduce the argument.
Once this commit is merged and deployed we will make another change to use the argument by reverting the reverts.