Skip to content

Capitalization: Rename LexisnexisInstantVerify to LexisNexisInstantVerify#9763

Merged
soniaconnolly merged 1 commit intomainfrom
sonia-rename-lexis-nexis-instant-verify-class
Dec 14, 2023
Merged

Capitalization: Rename LexisnexisInstantVerify to LexisNexisInstantVerify#9763
soniaconnolly merged 1 commit intomainfrom
sonia-rename-lexis-nexis-instant-verify-class

Conversation

@soniaconnolly
Copy link
Contributor

Capitalization: Rename LexisnexisInstantVerify to LexisNexisInstantVerify

Followup to comment on service name spelling in #9743

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!! LGTM

@soniaconnolly soniaconnolly merged commit 8d57654 into main Dec 14, 2023
@soniaconnolly soniaconnolly deleted the sonia-rename-lexis-nexis-instant-verify-class branch December 14, 2023 19:08
jmhooper added a commit that referenced this pull request Dec 14, 2023
jmhooper added a commit that referenced this pull request Dec 14, 2023
When we deployed the changes in #9763 and #9743 a new argument was introduced for the resolution proofing job. This argument was not recognized by old hosts performing the job which led to an argument error.

This commit reverts both of those and adds a commit to introduce the argument.

Once this commit is merged and deployed we will make another change to use the argument by reverting the reverts.

This commit adds a arg to the `ResolutionProofingJob` which was used in the changes in #9743. That commit was reverted. Old workers did not know about this arg so they raised an ArgumentError when they encountered it. We reverted that change so we could introduce the arg in this one and then revert the revert.

[skip changelog]
jmhooper added a commit that referenced this pull request Dec 14, 2023
jmhooper added a commit that referenced this pull request Dec 14, 2023
I reverted 2 changes in #9764 to address a bug in the way the arguments were passed to the ResolutionProofingJob. This commit reverts those 2 reverts to put the A/B test implementation back in place.

* Revert "Revert "LG-11671: Lexisnexis Instant Verify workflow A/B test (#9743)""
* Revert "Revert "Capitalization: Rename LexisnexisInstantVerify to LexisNexisInstantVerify (#9763)""

[skip changelog]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants