Revert changes for LexisNexis InstantVerify AB test

app/controllers/concerns/idv/ab_test_analytics_concern.rb

@@ -8,12 +8,6 @@ def ab_test_analytics_buckets
         buckets[:skip_hybrid_handoff] = idv_session&.skip_hybrid_handoff
       end
 
-      if defined?(document_capture_session_uuid)
-        lniv_args = LexisNexisInstantVerify.new(document_capture_session_uuid).
-          workflow_ab_test_analytics_args
-        buckets = buckets.merge(lniv_args)
-      end
-
       buckets.merge(acuant_sdk_ab_test_analytics_args)
     end
   end

app/jobs/resolution_proofing_job.rb

@@ -24,7 +24,7 @@ def perform(
     user_id: nil,
     threatmetrix_session_id: nil,
     request_ip: nil,
-    instant_verify_ab_test_discriminator: nil
+    instant_verify_ab_test_discriminator: nil # rubocop:disable Lint/UnusedMethodArgument
   )
     timer = JobHelpers::Timer.new
 
@@ -48,7 +48,6 @@ def perform(
       should_proof_state_id: should_proof_state_id,
       double_address_verification: double_address_verification,
       ipp_enrollment_in_progress: ipp_enrollment_in_progress,
-      instant_verify_ab_test_discriminator: instant_verify_ab_test_discriminator,
     )
 
     document_capture_session = DocumentCaptureSession.new(result_id: result_id)
@@ -76,10 +75,9 @@ def make_vendor_proofing_requests(
     request_ip:,
     should_proof_state_id:,
     double_address_verification:,
-    ipp_enrollment_in_progress:,
-    instant_verify_ab_test_discriminator:
+    ipp_enrollment_in_progress:
   )
-    result = resolution_proofer(instant_verify_ab_test_discriminator).proof(
+    result = resolution_proofer.proof(
       applicant_pii: applicant_pii,
       user_email: user&.confirmed_email_addresses&.first&.email,
       threatmetrix_session_id: threatmetrix_session_id,
@@ -115,9 +113,8 @@ def logger_info_hash(hash)
     logger.info(hash.to_json)
   end
 
-  def resolution_proofer(instant_verify_ab_test_discriminator)
-    @resolution_proofer ||= Proofing::Resolution::ProgressiveProofer.
-      new(instant_verify_ab_test_discriminator)
+  def resolution_proofer
+    @resolution_proofer ||= Proofing::Resolution::ProgressiveProofer.new
   end
 
   def add_threatmetrix_proofing_component(user_id, threatmetrix_result)

app/services/idv/agent.rb

@@ -24,7 +24,6 @@ def proof_resolution(
         should_proof_state_id: should_proof_state_id,
         trace_id: trace_id,
         result_id: document_capture_session.result_id,
-        instant_verify_ab_test_discriminator: document_capture_session.uuid,
         user_id: user_id,
         threatmetrix_session_id: threatmetrix_session_id,
         request_ip: request_ip,

app/services/proofing/resolution/progressive_proofer.rb

@@ -6,12 +6,6 @@ module Resolution
     #   2. The user has only provided one address for their residential and identity document
     #      address or separate residential and identity document addresses
     class ProgressiveProofer
-      attr_reader :instant_verify_ab_test_discriminator
-
-      def initialize(instant_verify_ab_test_discriminator = nil)
-        @instant_verify_ab_test_discriminator = instant_verify_ab_test_discriminator
-      end
-
       # @param [Hash] applicant_pii keys are symbols and values are strings, confidential user info
       # @param [Boolean] double_address_verification flag that indicates if user will have
       #   both state id address and current residential address verified. Note this value is here as
@@ -246,7 +240,7 @@ def resolution_proofer
             Proofing::Mock::ResolutionMockClient.new
           else
             Proofing::LexisNexis::InstantVerify::Proofer.new(
-              instant_verify_workflow: lexisnexis_instant_verify_workflow,
+              instant_verify_workflow: IdentityConfig.store.lexisnexis_instant_verify_workflow,
               account_id: IdentityConfig.store.lexisnexis_account_id,
               base_url: IdentityConfig.store.lexisnexis_base_url,
               username: IdentityConfig.store.lexisnexis_username,
@@ -258,12 +252,6 @@ def resolution_proofer
           end
       end
 
-      def lexisnexis_instant_verify_workflow
-        ab_test_variables = Idv::LexisNexisInstantVerify.new(instant_verify_ab_test_discriminator).
-          workflow_ab_testing_variables
-        ab_test_variables[:instant_verify_workflow]
-      end
-
       def state_id_proofer
         @state_id_proofer ||=
           if IdentityConfig.store.proofer_mock_fallback

config/application.yml.default

@@ -168,9 +168,6 @@ lexisnexis_phone_finder_timeout: 1.0
 lexisnexis_phone_finder_workflow: customers.gsa2.phonefinder.workflow
 lexisnexis_instant_verify_timeout: 1.0
 lexisnexis_instant_verify_workflow: gsa2.chk32.test.wf
-lexisnexis_instant_verify_workflow_ab_testing_enabled: false
-lexisnexis_instant_verify_workflow_ab_testing_percent: 5
-lexisnexis_instant_verify_workflow_alternate: gsa2.chk14.test.wf
 # TrueID DocAuth Integration
 lexisnexis_trueid_account_id: '12345'
 lexisnexis_trueid_username: test_username

config/initializers/ab_tests.rb

@@ -18,14 +18,4 @@ module AbTests
         0,
     },
   )
-
-  LEXISNEXIS_INSTANT_VERIFY_WORKFLOW = AbTestBucket.new(
-    experiment_name: 'LexisNexis Instant Verify Workflow',
-    buckets: {
-      use_alternate_workflow:
-        IdentityConfig.store.lexisnexis_instant_verify_workflow_ab_testing_enabled ?
-          IdentityConfig.store.lexisnexis_instant_verify_workflow_ab_testing_percent :
-          0,
-    },
-  )
 end

lib/identity_config.rb

@@ -270,9 +270,6 @@ def self.build_store(config_map)
     config.add(:lexisnexis_hmac_secret_key, type: :string)
     config.add(:lexisnexis_instant_verify_timeout, type: :float)
     config.add(:lexisnexis_instant_verify_workflow, type: :string)
-    config.add(:lexisnexis_instant_verify_workflow_ab_testing_enabled, type: :boolean)
-    config.add(:lexisnexis_instant_verify_workflow_ab_testing_percent, type: :integer)
-    config.add(:lexisnexis_instant_verify_workflow_alternate, type: :string)
     config.add(:lexisnexis_password, type: :string)
     config.add(:lexisnexis_phone_finder_timeout, type: :float)
     config.add(:lexisnexis_phone_finder_workflow, type: :string)

spec/controllers/concerns/idv/ab_test_analytics_concern_spec.rb

@@ -9,54 +9,35 @@
   describe '#ab_test_analytics_buckets' do
     controller(ApplicationController) do
       include Idv::AbTestAnalyticsConcern
-
-      def document_capture_session_uuid
-        SecureRandom.uuid
-      end
     end
 
     let(:acuant_sdk_args) { { as_bucket: :as_value } }
-    let(:instant_verify_sdk_args) { { iv_bucket: :iv_value } }
-    let(:lniv) { Idv::LexisNexisInstantVerify.new(controller.document_capture_session_uuid) }
 
     before do
       allow(subject).to receive(:current_user).and_return(user)
       expect(subject).to receive(:acuant_sdk_ab_test_analytics_args).
         and_return(acuant_sdk_args)
-      allow(Idv::LexisNexisInstantVerify).to receive(:new).
-        and_return(lniv)
-      expect(lniv).to receive(:workflow_ab_test_analytics_args).
-        and_return(instant_verify_sdk_args)
     end
 
     context 'idv_session is available' do
       before do
         sign_in(user)
         expect(subject).to receive(:idv_session).once.and_return(idv_session)
       end
-
       it 'includes acuant_sdk_ab_test_analytics_args' do
         expect(controller.ab_test_analytics_buckets).to include(acuant_sdk_args)
       end
 
-      it 'includes lexisnexis_instant_verify_sdk_ab_test_analytics_args' do
-        expect(controller.ab_test_analytics_buckets).to include(instant_verify_sdk_args)
-      end
-
       it 'includes skip_hybrid_handoff' do
         idv_session.skip_hybrid_handoff = :shh_value
         expect(controller.ab_test_analytics_buckets).to include({ skip_hybrid_handoff: :shh_value })
       end
     end
 
     context 'idv_session is not available' do
-      it 'still includes acuant_sdk_ab_test_analytics_args' do
+      it 'still works' do
         expect(controller.ab_test_analytics_buckets).to include(acuant_sdk_args)
       end
-
-      it 'still includes lexisnexis_instant_verify_sdk_ab_test_analytics_args' do
-        expect(controller.ab_test_analytics_buckets).to include(instant_verify_sdk_args)
-      end
     end
   end
 end