LG-11759: Add inline device nickname editing for security keys#9807
Merged
LG-11759: Add inline device nickname editing for security keys#9807
Conversation
zachmargolis
approved these changes
Dec 20, 2023
jmdembe
approved these changes
Dec 20, 2023
aduth
force-pushed
the
aduth-lg-11759-manage-security-keys
branch
from
649ac27 to
65973ae
Compare
mdiarra3
approved these changes
Dec 21, 2023
Contributor
|
Looks like it "fails" due to content freeze. |
changelog: User-Facing Improvements, Security Key, Add inline rename and deletion to account management
See: #9807 (comment) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
aduth
force-pushed
the
aduth-lg-11759-manage-security-keys
branch
from
65973ae to
1166b87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-11759
🛠 Summary of changes
Adds a rename/deletion interaction for Security Keys, similar to and extending what was introduced with LG-11454 (#9764).
📜 Testing Plan
👀 Screenshots