Skip to content

LG-11454: Add rename support for face or touch unlock#9674

Merged
aduth merged 1 commit intomainfrom
aduth-lg-11454-manage-auth
Dec 15, 2023
Merged

LG-11454: Add rename support for face or touch unlock#9674
aduth merged 1 commit intomainfrom
aduth-lg-11454-manage-auth

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Nov 28, 2023

🎫 Ticket

LG-11454

🛠 Summary of changes

Adds the option for a user to manage (rename or delete) a Face or Touch Unlock authenticator from within the account dashboard, managed inline without the need to navigate to a separate screen.

📜 Testing Plan

  1. (Prerequisite) Have an account with Face or Touch Unlock
  2. Go to http://localhost:3000
  3. Sign in
  4. On account dashboard, click "Manage" for Face or Touch Unlock
  5. Observe that you are able to manage the authenticator inline
  6. Disable JavaScript and repeat steps 4 and 5, verifying that there is feature parity in the no-JavaScript experience

👀 Screenshots

manage-webauthn.mov

@aduth aduth force-pushed the aduth-lg-11454-manage-auth branch from ae2bf82 to 17e0889 Compare December 7, 2023 15:43
@aduth aduth marked this pull request as ready for review December 8, 2023 17:47
@aduth aduth requested a review from a team December 8, 2023 17:47
@aduth
Copy link
Contributor Author

aduth commented Dec 8, 2023

Okay, this should be fully code-complete now, and all tests are passing. I've also updated the original comment with a new screen recording after some content and behavior revisions.

I recognize this pull request is very large, coming in just under 3000 lines added. I'll plan to extract some changes to separate pull requests to get this one into a more manageable state, but it's otherwise ready for feedback.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mdiarra3 mdiarra3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as a whole, tested and worked as expected. Also know this will be split up into smaller PRs for easier commenting

@aduth aduth force-pushed the aduth-lg-11454-manage-auth branch from d773f75 to 14979bb Compare December 12, 2023 18:02
@aduth aduth force-pushed the aduth-lg-11454-manage-auth branch 2 times, most recently from fc223c9 to a430def Compare December 13, 2023 17:04
@aduth
Copy link
Contributor Author

aduth commented Dec 13, 2023

There were a couple separate pull requests split from this one:

#9742 was the biggest, and ensures that the route controllers are present during the 50/50 deploy state for when the changes here are deployed.

changelog: User-Facing Improvements, Face or Touch Unlock, Add option to rename face or touch unlock in account dashboard

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
@aduth aduth force-pushed the aduth-lg-11454-manage-auth branch from a430def to 77bf195 Compare December 15, 2023 14:16
@aduth aduth merged commit 46d206b into main Dec 15, 2023
@aduth aduth deleted the aduth-lg-11454-manage-auth branch December 15, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants