LG-11454: Add rename support for face or touch unlock#9674
Conversation
app/controllers/api/internal/two_factor_authentication/webauthn_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/api/internal/two_factor_authentication/webauthn_controller.rb
Outdated
Show resolved
Hide resolved
ae2bf82 to
17e0889
Compare
|
Okay, this should be fully code-complete now, and all tests are passing. I've also updated the original comment with a new screen recording after some content and behavior revisions. I recognize this pull request is very large, coming in just under 3000 lines added. I'll plan to extract some changes to separate pull requests to get this one into a more manageable state, but it's otherwise ready for feedback. |
app/javascript/packages/manageable-authenticator/manageable-authenticator-element.ts
Outdated
Show resolved
Hide resolved
0c100fd to
d773f75
Compare
mdiarra3
left a comment
There was a problem hiding this comment.
Looks good to me as a whole, tested and worked as expected. Also know this will be split up into smaller PRs for easier commenting
d773f75 to
14979bb
Compare
fc223c9 to
a430def
Compare
|
There were a couple separate pull requests split from this one:
#9742 was the biggest, and ensures that the route controllers are present during the 50/50 deploy state for when the changes here are deployed. |
changelog: User-Facing Improvements, Face or Touch Unlock, Add option to rename face or touch unlock in account dashboard Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
a430def to
77bf195
Compare
🎫 Ticket
LG-11454
🛠 Summary of changes
Adds the option for a user to manage (rename or delete) a Face or Touch Unlock authenticator from within the account dashboard, managed inline without the need to navigate to a separate screen.
📜 Testing Plan
👀 Screenshots
manage-webauthn.mov