LG-11454 (1): Add controllers for WebAuthn management#9742
Merged
Conversation
changelog: Upcoming Features, Face or Touch Unlock, Add new renaming interface for face or touch unlock
zachmargolis
approved these changes
Dec 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Partially implements LG-11454
🛠 Summary of changes
Adds new Rails controllers for managing WebAuthn authenticators, to be used as part of LG-11454 to manage (rename or delete) an authenticator.
Currently, these routes are accessible but not exposed anywhere within the application. This is split from #9674, in order to reduce the size of that pull request, and to ensure that the routes are available during the 50/50 deployment state for the deploy which would include the frontend interface revisions.
📜 Testing Plan
Ensure build passes.
Optionally, it is expected that the routes for managing an authenticator would be available, including user-facing views and REST API routes. If you know the ID associated with your WebAuthn configuration†, you can visit http://localhost:3000/manage/webauthn/123 (replace the last path portion with ID) to manage the device, which should work as expected.
† You can find this in a
rails consoleas such, replacing the email address with your own: