Remove unimplemented clearfix CSS class from static error pages#9799
Merged
Remove unimplemented clearfix CSS class from static error pages#9799
Conversation
changelog: Internal, Code Quality, Remove unused style reference from error page markup
mitchellhenke
approved these changes
Dec 19, 2023
Merged
This was referenced Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes a reference to a
clearfixclass which does not exist in the context of static error pages.These error pages load a reduced, static stylesheet which does not implement
.clearfix.This is also an incremental step toward removing
clearfixusage across the application, prompted partly by #9674.📜 Testing Plan
Visit each page and observe no visual regressions, e.g. http://localhost:3000/401.html