LG 11145 Break up MFA selection presenter classes for Phone Presenters

[kevinsmaster5]

🎫 Ticket

LG-11145

🛠 Summary of changes

Split up Phone, SMS, and Voice presenters into Set up and Sign in classes as a follow up to #9211

[kevinsmaster5]

WIP - looking to see how and if SMS and Voice can be consolidated into Phone.

[aduth]

We can follow-up separately, but if this is the last method to be refactored, we can probably remove these classes altogether now.

Although I see that I had made a mistake in my refactoring of personal key presenters which are still using this as the base class, so maybe I can address it at the same time I fix that up.

[aduth]

A few minor comments, but LGTM otherwise 👍

[zachmargolis]

method is a ruby built-in method so I feel like it would be good to avoid overriding that if we can? Could we name the attribute something else? like delivery_method?

[kevinsmaster5]

That's a fair point. It would have to be changed on all of the MFA presenters if so.

[aduth]

It might be a good idea, though in this case we're porting over an existing pair of methods:

identity-idp/app/presenters/two_factor_authentication/sms_selection_presenter.rb

Lines 3 to 5 in 59755ae

	def method
	:sms
	end

identity-idp/app/presenters/two_factor_authentication/voice_selection_presenter.rb

Lines 3 to 5 in 59755ae

	def method
	:voice
	end

It's also already used throughout every other 2FA presenter:

• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/set_up_auth_app_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/set_up_backup_code_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/set_up_piv_cac_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/set_up_webauthn_platform_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/set_up_webauthn_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_auth_app_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_backup_code_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_personal_key_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_piv_cac_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_webauthn_platform_selection_presenter.rb
• https://github.com/18F/identity-idp/blob/main/app/presenters/two_factor_authentication/sign_in_webauthn_selection_presenter.rb

That being said, the only place I see it actually being used is in the presenter type method, and the only purpose that seemed to serve was for the label method's switches, which should all be effectively removed as of this pull request. I could probably clean this up as part of the follow-on work I mentioned at #9560 (comment) .