LG-11542 Texas conditional hint text for id number

[svalexander]

🎫 Ticket

LG-11542

🛠 Summary of changes

Added ability to change the id number hint text based on which state the user selects. This pr specifically adds state specific text for Texas.
The file formerly named puerto-rico-guidance was updated in this pr. It's renamed and updated to allow future additions for state specific hint text.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

• Go through ipp flow and arrive at state id page
• Scroll down to "issuing state" drop down
• Confirm hint under id number is the default text
• Select "Texas"
• Confirm hint under "id number" is the Texas-specific text
• Select another state
• Confirm hint under "id number" is the default text
• Change language to es
• Confirm hint under id number is the default text
• Select "Texas"
• Confirm hint under "id number" is the Texas-specific text
• Select another state
• Confirm hint under "id number" is the default text
• Change language to fr
• Confirm hint under id number is the default text
• Select "Texas"
• Confirm hint under "id number" is the Texas-specific text
• Select another state
• Confirm hint under "id number" is the default text

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

En default hint:

En Texas hint:

Es default hint:

Es Texas hint:

Fr default hint:

Fr Texas hint:

[zachmargolis]

are we going to add FL-specific text?
if not, we can just let this call through to the default, right?

Suggested change

	case 'FL':
	element.innerHTML = t('in_person_proofing.form.state_id.state_id_number_hint_html');
	break;

[svalexander]

I added this as a placeholder as we will add florida specific text in another ticket. But I can remove it for this pr.

[zachmargolis]

Yeah it's very easy to add to later, I'd agree and remove from this PR

[zachmargolis]

I'd consider breaking this into two helper functions? It's nice to be able to directly return from a switch/case statement so we don't have to worry about adding break and side effects and stuff, so like:

  document.querySelectorAll('.jurisdiction-extras').forEach((element) => {
    element.innerHTML = jurisdictionExtraHelperText(forJurisdictionCode);
  });
  // ...


  function jurisdictionExtraHelperText(jurisdiction) {
    switch(jurisdiction) {
    case 'TX':
      return '...';
    default:
      return '...;
    }
  }

[svalexander]

that's definitely neater

[carmenrosalop]

This looks good! My only comment is that the second sentence in the hint text in English needs a period.

[svalexander]

This looks good! My only comment is that the second sentence in the hint text in English needs a period.

just updated the text and screenshot with the added punctuation

[carmenrosalop]

Looks good! Thank you Shannon