Merged
Conversation
aduth
reviewed
Sep 15, 2023
app/presenters/two_factor_authentication/set_up_selection_presenter.rb
Outdated
Show resolved
Hide resolved
kevinsmaster5
approved these changes
Sep 19, 2023
Contributor
kevinsmaster5
left a comment
kevinsmaster5
left a comment
There was a problem hiding this comment.
It looks good!
Tested locally and no problems noted.
Contributor
|
Is this pull request intended as a proof-of-concept limited to a single authentication method (TOTP) with the expectation that the rest will be ported in follow-up pull requests? |
Contributor
Author
|
Yes, this is the initial PR with proof of concept and base options available, and then we can do follow up requests per pull requests for each additional authentication method. @aduth |
aduth
approved these changes
Sep 26, 2023
app/presenters/two_factor_authentication/set_up_auth_app_selection_presenter.rb
Show resolved
Hide resolved
Merged
This was referenced Oct 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10687
🛠 Summary of changes
This would create the workflow for creating Presenters for the Options presenter, with Sign in and Set up presenters to decouple the logic into seperate presenters
📜 Testing Plan
Adding MFA options and selecting a bunch of MFA options still works as expected on account creation
For Sign in, users can look at list of MFA options when clicking choose another authentication method, and can still sign in without issue.