LG 11145 Break up MFA selection presenter classes for Phone Presenters

app/models/phone_configuration.rb

@@ -22,11 +22,13 @@ def selection_presenters
     capabilities = PhoneNumberCapabilities.new(phone, phone_confirmed: !!confirmed_at?)
 
     if capabilities.supports_sms?
-      options << TwoFactorAuthentication::SmsSelectionPresenter.new(user:, configuration: self)
+      options << TwoFactorAuthentication::SignInPhoneSelectionPresenter.
+        new(user:, configuration: self, method: :sms)
     end
 
     if capabilities.supports_voice?
-      options << TwoFactorAuthentication::VoiceSelectionPresenter.new(user:, configuration: self)
+      options << TwoFactorAuthentication::SignInPhoneSelectionPresenter.
+        new(user:, configuration: self, method: :voice)
     end
 
     options

app/presenters/two_factor_authentication/selection_presenter.rb

@@ -68,27 +68,11 @@ def disabled?
     private
 
     def login_label(type)
-      case type
-      when 'sms'
-        t('two_factor_authentication.login_options.sms')
-      when 'voice'
-        t('two_factor_authentication.login_options.voice')
-      else
-        raise "Unsupported login method: #{type}"
-      end
+      raise "Unsupported login method: #{type}"
     end
 
     def setup_label(type)
-      case type
-      when 'phone'
-        t('two_factor_authentication.two_factor_choice_options.phone')
-      when 'sms'
-        t('two_factor_authentication.two_factor_choice_options.sms')
-      when 'voice'
-        t('two_factor_authentication.two_factor_choice_options.voice')
-      else
-        raise "Unsupported setup method: #{type}"
-      end
+      raise "Unsupported setup method: #{type}"
     end
 
     def login_info(type)

app/presenters/two_factor_authentication/phone_selection_presenter.rb → app/presenters/two_factor_authentication/set_up_phone_selection_presenter.rb

@@ -1,15 +1,11 @@
 module TwoFactorAuthentication
-  class PhoneSelectionPresenter < SelectionPresenter
+  class SetUpPhoneSelectionPresenter < SetUpSelectionPresenter
     def method
       :phone
     end
 
-    def type
-      if MfaContext.new(configuration&.user).phone_configurations.many?
-        "#{super}_#{configuration.id}"
-      else
-        super
-      end
+    def label
+      t('two_factor_authentication.two_factor_choice_options.phone')
     end
 
     def info

app/presenters/two_factor_authentication/sign_in_phone_selection_presenter.rb

@@ -0,0 +1,55 @@
+module TwoFactorAuthentication
+  class SignInPhoneSelectionPresenter < SignInSelectionPresenter
+    attr_reader :configuration, :user, :method
+
+    def initialize(user:, configuration:, method:)
+      @user = user
+      @configuration = configuration
+      @method = method
+    end
+
+    def type
+      if MfaContext.new(configuration&.user).phone_configurations.many?
+        "#{super}_#{configuration.id}"
+      else
+        super
+      end
+    end
+
+    def label
+      if method.to_s == 'sms'
+        t('two_factor_authentication.login_options.sms')
+      elsif method.to_s == 'voice'
+        t('two_factor_authentication.login_options.voice')
+      end
+    end
+
+    def info
+      case method
+      when :sms
+        t(
+          'two_factor_authentication.login_options.sms_info_html',
+          phone: configuration.masked_phone,
+        )
+      when :voice
+        t(
+          'two_factor_authentication.login_options.voice_info_html',
+          phone: configuration.masked_phone,
+        )
+      else
+        t('two_factor_authentication.two_factor_choice_options.phone_info')
+      end
+    end
+
+    def disabled?
+      case method
+      when :sms
+        OutageStatus.new.vendor_outage?(:sms)
+      when :voice
+        OutageStatus.new.vendor_outage?(:voice)
+      else
+        OutageStatus.new.all_phone_vendor_outage?
+      end
+    end
+  end
+end

app/presenters/two_factor_options_presenter.rb

@@ -34,7 +34,7 @@ def all_user_selected_options
     [
       TwoFactorAuthentication::SetUpWebauthnPlatformSelectionPresenter.new(user: user),
       TwoFactorAuthentication::SetUpAuthAppSelectionPresenter.new(user: user),
-      TwoFactorAuthentication::PhoneSelectionPresenter.new(user: user),
+      TwoFactorAuthentication::SetUpPhoneSelectionPresenter.new(user: user),
       TwoFactorAuthentication::SetUpBackupCodeSelectionPresenter.new(user: user),
       TwoFactorAuthentication::SetUpWebauthnSelectionPresenter.new(user: user),
       TwoFactorAuthentication::SetUpPivCacSelectionPresenter.new(user: user),
@@ -116,7 +116,7 @@ def phone_options
     if piv_cac_required? || phishing_resistant_only? || IdentityConfig.store.hide_phone_mfa_signup
       return []
     else
-      [TwoFactorAuthentication::PhoneSelectionPresenter.new(user: user)]
+      [TwoFactorAuthentication::SetUpPhoneSelectionPresenter.new(user: user)]
     end
   end
 

config/locales/two_factor_authentication/en.yml

@@ -163,8 +163,6 @@ en:
         (toll) phone numbers.
       piv_cac: Government employee ID
       piv_cac_info: PIV/CAC cards for government and military employees. Desktop only.
-      sms: Text message / SMS
-      voice: Phone call
       webauthn: Security key
       webauthn_info: A physical device, often shaped like a USB drive, that you plug
         in to your device.

config/locales/two_factor_authentication/es.yml

@@ -173,8 +173,6 @@ es:
       piv_cac: Identificación de empleado gubernamental
       piv_cac_info: Credenciales PIV/CAC para empleados gubernamentales y del
         ejército. Únicamente versión de escritorio.
-      sms: Mensaje de texto / SMS
-      voice: Llamada telefónica
       webauthn: Clave de seguridad
       webauthn_info: Un dispositivo físico que suele tener la forma de una unidad USB
         y se conecta a su dispositivo.

config/locales/two_factor_authentication/fr.yml

@@ -182,8 +182,6 @@ fr:
       piv_cac: Carte d’identification des employés du gouvernement
       piv_cac_info: Cartes PIV/CAC pour les fonctionnaires et les militaires. Bureau
         uniquement.
-      sms: SMS
-      voice: Appel téléphonique
       webauthn: Clef de sécurité
       webauthn_info: Un appareil physique, souvent en forme de clé USB, que vous
         branchez sur votre appareil.

spec/presenters/two_factor_authentication/phone_selection_presenter_spec.rb → spec/presenters/two_factor_authentication/set_up_phone_selection_presenter_spec.rb

@@ -1,15 +1,13 @@
 require 'rails_helper'
 
-RSpec.describe TwoFactorAuthentication::PhoneSelectionPresenter do
+RSpec.describe TwoFactorAuthentication::SetUpPhoneSelectionPresenter do
   let(:user_without_mfa) { create(:user) }
   let(:user_with_mfa) { create(:user, :with_phone) }
-  let(:presenter_with_mfa) { described_class.new(configuration: phone, user: user_with_mfa) }
-  let(:presenter_without_mfa) { described_class.new(configuration: phone, user: user_without_mfa) }
+  let(:presenter_with_mfa) { described_class.new(user: user_with_mfa) }
+  let(:presenter_without_mfa) { described_class.new(user: user_without_mfa) }
 
   describe '#info' do
     context 'when a user does not have a phone configuration (first time)' do
-      let(:phone) { nil }
-
       it 'includes a note about choosing voice or sms' do
         expect(presenter_without_mfa.info).
           to include(t('two_factor_authentication.two_factor_choice_options.phone_info'))
@@ -28,8 +26,6 @@
   end
 
   describe '#disabled?' do
-    let(:phone) { build(:phone_configuration, phone: '+1 888 867-5309') }
-
     it { expect(presenter_without_mfa.disabled?).to eq(false) }
 
     context 'all phone vendor outage' do
@@ -42,7 +38,6 @@
   end
 
   describe '#mfa_configuration' do
-    let(:phone) { nil }
     it 'returns an empty string when user has not configured this authenticator' do
       expect(presenter_without_mfa.mfa_configuration_description).to eq('')
     end

spec/presenters/two_factor_authentication/sign_in_phone_selection_presenter_spec.rb

@@ -0,0 +1,92 @@
+require 'rails_helper'
+
+RSpec.describe TwoFactorAuthentication::SignInPhoneSelectionPresenter do
+  let(:user) { create(:user, :with_phone) }
+  let(:configuration) { create(:phone_configuration, user: user) }
+
+  let(:presenter) do
+    described_class.new(user: user, configuration: configuration, method: 'phone')
+  end
+
+  describe '#type' do
+    it 'returns phone appended with configuration id' do
+      expect(presenter.type).to eq "phone_#{configuration.id}"
+    end
+  end
+
+  describe '#info' do
+    it 'raises with missing translation' do
+      expect(presenter.info).to eq(
+        t('two_factor_authentication.two_factor_choice_options.phone_info'),
+      )
+    end
+    context 'with sms method' do
+      let(:presenter) do
+        described_class.new(user: user, configuration: configuration, method: :sms)
+      end
+      it 'returns the correct translation for sms' do
+        expect(presenter.info).to eq(
+          t(
+            'two_factor_authentication.login_options.sms_info_html',
+            phone: configuration.masked_phone,
+          ),
+        )
+      end
+    end
+    context 'with voice method' do
+      let(:presenter) do
+        described_class.new(user: user, configuration: configuration, method: :voice)
+      end
+      it 'returns the correct translation for voice' do
+        expect(presenter.info).to eq(
+          t(
+            'two_factor_authentication.login_options.voice_info_html',
+            phone: configuration.masked_phone,
+          ),
+        )
+      end
+    end
+  end
+
+  describe '#disabled?' do
+    let(:user_without_mfa) { create(:user) }
+    let(:phone) { build(:phone_configuration, phone: '+1 888 867-5309') }
+    let(:presenter_without_mfa) do
+      described_class.new(configuration: phone, user: user_without_mfa, method: 'phone')
+    end
+    it { expect(presenter_without_mfa.disabled?).to eq(false) }
+
+    context 'all phone vendor outage' do
+      before do
+        allow_any_instance_of(OutageStatus).to receive(:all_phone_vendor_outage?).and_return(true)
+      end
+
+      it { expect(presenter_without_mfa.disabled?).to eq(true) }
+    end
+
+    context 'voice vendor outage' do
+      let(:presenter_without_mfa) do
+        described_class.new(configuration: phone, user: user, method: method)
+      end
+      let(:method) { :voice }
+      before do
+        allow_any_instance_of(OutageStatus).to receive(:vendor_outage?).with(:voice).
+          and_return(true)
+      end
+
+      it { expect(presenter_without_mfa.disabled?).to eq(true) }
+    end
+
+    context 'sms vendor outage' do
+      let(:presenter_without_mfa) do
+        described_class.new(configuration: phone, user: user, method: method)
+      end
+      let(:method) { :sms }
+      before do
+        allow_any_instance_of(OutageStatus).to receive(:vendor_outage?).with(:sms).and_return(true)
+      end
+
+      it { expect(presenter_without_mfa.disabled?).to eq(true) }
+    end
+  end
+end