LG-9872: Add missing interpolation value for personal key alert#8531
Merged
LG-9872: Add missing interpolation value for personal key alert#8531
Conversation
changelog: Bug Fixes, Sign-In Alerts, Fix message for personal key MFA sign-in missing "app_name" value
matthinz
approved these changes
Jun 2, 2023
Contributor
matthinz
left a comment
There was a problem hiding this comment.
LGTM, one possibility for adding a new test
Caught by the new spec helper 🙌
mdiarra3
approved these changes
Jun 5, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9872
Fixes #8443
🛠 Summary of changes
Fixes the notification sent when signing in using Personal Key as the multi-factor authentication method, which previously included the literal
%{app_name}rather than "Login.gov".As a proactive step to try to identify these sorts of issues sooner, the changes also include a monkeypatch to the
I18n.tmethod when tests are run, raising an exception if the result of the translation includes a lingering interpolation variable.📜 Testing Plan
(Note that this is difficult to test in deployed environments because it relates to a legacy behavior where "personal key" was supported as an MFA method without an existing identity-verified account)
User.find_with_email('<email here>').profiles.delete_all(substitute "<email here>" with your chosen email)