LG-11126 Update Start over verifying your identity screen by theabrad · Pull Request #9313 · 18F/identity-idp

theabrad · 2023-10-04T19:14:15Z

🎫 Ticket

🛠 Summary of changes

Updated the text for the confirm start over page for a user trying to change their address through the verify by mail flow.

ETA: @solipet and @soniaconnolly edited this PR to add a new template rather than change the existing template. We added a new route, which we can start using in the next deploy. Meanwhile we choose the template based on the referer.

📜 Testing Plan

We currently do not have a mechanism to reach this page through canceling in the IdV verify by mail flow (it is being addressed in https://cm-jira.usa.gov/browse/LG-11125) except on the enter gpo code page.

Go through IdV
Select the verify by mail option
Request a letter
In your browser visit /verify/by_mail/confirm_start_over

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Existing:

New:

English:

Spanish:

French:

changelog: User-Facing Improvements, IdV By Mail, update text in start over verifying identity screen

amirbey · 2023-10-05T18:25:52Z

config/locales/idv/es.yml

            este teléfono?'
          standard: '¿Cancelar la verificación de su identidad?'
-        start_over: Empezar de nuevo a verificar su identidad
+        start_over: ¿Empezar de nuevo a verificar su identidad?


overall ... LGTM
however, this key is also used on /verify/cancel page ... do we want to make it a question there too?

I'll create another translation for one with the question mark.

amirbey · 2023-10-05T18:36:51Z

also, could be helpful to verify the content changes exists in the feature spec 👍🏿

soniaconnolly

Approved accidentally, don't see how to undo. @amirbey covered the issues, so please wait until he approves.

…6-update-idv-start-over

solipet

Ran through the step - looks great!

solipet

After some confusion, we now realize that the interstitial updated for the cancel from the Request Letter screen should not be the same as the one from the cancel from the Enter Code screen. The latter should still have the warnings about invalidating the verification code.

config/locales/idv/en.yml

…_address Co-authored-by: Doug Price <douglas.price@gsa.gov>

Add source param to indicate whether referer is request_letter

Co-authored-by: Doug Price <douglas.price@gsa.gov>

And analytics

…-idv-start-over

matthinz · 2023-10-19T19:43:01Z

app/controllers/idv/confirm_start_over_controller.rb

+      if request.referer == idv_request_letter_url
+        analytics.idv_gpo_confirm_start_over_before_letter_visited
+        render 'idv/confirm_start_over/before_letter'
+      else


I did a double take at this initially but then saw the note in the description about how this is temporary. This is fine for now, but I don't want any referer-checking code sitting around long term.

Maybe just call it out a little bit (and clarify that we're calling out to before_letter here):

Suggested change

if request.referer == idv_request_letter_url

analytics.idv_gpo_confirm_start_over_before_letter_visited

render 'idv/confirm_start_over/before_letter'

else

# Temporarily check referer until link in request letter view is updated

if request.referer == idv_request_letter_url

before_letter

else

Followup PR: #9423

Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>

…-idv-start-over

* LG-11083: Enable USPS Public Endpoint (#9355) * changelog: Internal, In-Person Proofing, Enable public USPS post office search * Use EnrollmentHelper to switch between mock/real thing * Try behaves_like * Revert shared examples for now * Use full name * Update report mailer preview to be more realistic (#9419) **How**: stubs CloudwatchClient changelog: Internal, Reporting, Updates report preview to use live code * Add analytics section to frontend documentation (#9421) * Add analytics section to frontend documentation changelog: Internal, Documentation, Add analytics frontend documentation * link to correct javascript package * LG-11101: Support multiple valid MFA to satisfy authentication request (#9335) changelog: User-Facing Improvements, MFA, Avoid prompting for MFA in some scenarios where a recent MFA satisfies the requirement * LG-11148 | Adds monthly report on total verified users (#9376) changelog: Internal, Reporting, Monthly report now includes total verified users Also incorporates LG-11150 Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> * Remove second MFA prompt exception for strict MFA requirement (#9422) changelog: User-Facing Improvements, MFA Setup, Add second MFA reminder screen for single-MFA accounts when signing in at AAL2 * LG-11126 Update Start over verifying your identity screen (#9313) * change text for start over verify screen * add translations for page * add changelog changelog: User-Facing Improvements, IdV By Mail, update text in start over verifying identity screen * remove unused i18n * create new translation with question mark added * current step indicator for user not in gpo flow yet * a missing period * Restore deleted translations, and rename start_over to start_over_new_address Co-authored-by: Doug Price <douglas.price@gsa.gov> * New template for confirm start over from request_letter Add source param to indicate whether referer is request_letter * Update specs to check for correct template Co-authored-by: Doug Price <douglas.price@gsa.gov> * Add before_letter route for new screen, don't use it yet And analytics * Lint, unused arg in analytics_events * alphabetization lint * Add suggested comment Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> * lints --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> * LG-11198: Update address text (#9420) Update address text changelog: User-Facing Improvements, IdV, Update text for address * LG-10922: Display new headings for Hybrid Handoff page on AB test (#9316) * changelog: User-Facing Improvements, Doc Auth, Display new headings for Hybrid Handoff page on AB test Adds: * Conditional headers depending on which flag is on * Hybrid handoff show view test * Translations * LG-11235: Rename double address verification as ipp_enrollment_in_progress (#9390) * Removed double address verification replaced with ipp_enrollment_in_progress * changelog: Internal, In-person Proofing, change DAV references to reflect reality * Change test description to be closer to what is being changed in the controller * Addressing 50/50 state concerns in proofer and adjudicator * Addressing linter issues * Set missing initial value for dav * Moving arg with default value to end of list * Apply suggestions from code review Adding proper input to job_arguments hash. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Adding note about existing ticket for work post 50/50 state * Resolving Shannon's comments * Adding back in test for dav, need reader on adjudicator * Adding back in test for dav, need reader on adjudicator --------- Co-authored-by: jack.ryan@gsa.gov <johnaryan@fcoh2j-f4t79kf4.myfiosgateway.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add --deflate option to data-pull and action-account scripts (#9424) changelog: Internal, Scripts, Add --deflate option to data-pull and action-account scripts --------- Co-authored-by: Matt Gardner <wilburnforce@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: jc-gsa <104452882+jc-gsa@users.noreply.github.com> Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com> Co-authored-by: Jack Ryan <jackryan@navapbc.com> Co-authored-by: jack.ryan@gsa.gov <johnaryan@fcoh2j-f4t79kf4.myfiosgateway.com>

theabrad added 3 commits October 2, 2023 14:58

change text for start over verify screen

49471b6

add translations for page

4540ba6

add changelog

6fdc740

changelog: User-Facing Improvements, IdV By Mail, update text in start over verifying identity screen

theabrad requested a review from a team October 4, 2023 19:14

remove unused i18n

5429f9a

amirbey reviewed Oct 5, 2023

View reviewed changes

soniaconnolly approved these changes Oct 6, 2023

View reviewed changes

theabrad mentioned this pull request Oct 10, 2023

Jmax/lg 11125 update verify your address screen #9329

Merged

6 tasks

theabrad added 4 commits October 10, 2023 14:51

create new translation with question mark added

d8dd952

Merge branch 'main' of github.com:18F/identity-idp into abrad-lg-1112…

8aca6b2

…6-update-idv-start-over

Merge branch 'main' of github.com:18F/identity-idp into abrad-lg-1112…

c2c9aaf

…6-update-idv-start-over

current step indicator for user not in gpo flow yet

c330a57

solipet requested a review from amirbey October 16, 2023 21:16

solipet approved these changes Oct 16, 2023

View reviewed changes

a missing period

6e52ef1

solipet added the status - do not merge label Oct 16, 2023

solipet requested changes Oct 16, 2023

View reviewed changes

config/locales/idv/en.yml Show resolved Hide resolved

Restore deleted translations, and rename start_over to start_over_new…

f8b463a

…_address Co-authored-by: Doug Price <douglas.price@gsa.gov>

soniaconnolly force-pushed the abrad-lg-11126-update-idv-start-over branch from f2bcbbc to 4412633 Compare October 18, 2023 21:49

New template for confirm start over from request_letter

57c1d7e

Add source param to indicate whether referer is request_letter

soniaconnolly force-pushed the abrad-lg-11126-update-idv-start-over branch from 4412633 to 57c1d7e Compare October 18, 2023 21:55

Update specs to check for correct template

140e798

Co-authored-by: Doug Price <douglas.price@gsa.gov>

soniaconnolly requested review from solipet and soniaconnolly October 18, 2023 22:03

soniaconnolly added 3 commits October 19, 2023 08:45

Add before_letter route for new screen, don't use it yet

39d9724

And analytics

Lint, unused arg in analytics_events

b7c5ee4

Merge remote-tracking branch 'origin/main' into abrad-lg-11126-update…

c10217f

…-idv-start-over

soniaconnolly removed the status - do not merge label Oct 19, 2023

alphabetization lint

150335a

matthinz reviewed Oct 19, 2023

View reviewed changes

matthinz approved these changes Oct 19, 2023

View reviewed changes

soniaconnolly and others added 3 commits October 19, 2023 14:58

Add suggested comment

20a6186

Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>

Merge remote-tracking branch 'origin/main' into abrad-lg-11126-update…

138977b

…-idv-start-over

lints

492cf60

solipet force-pushed the abrad-lg-11126-update-idv-start-over branch from b24ecc5 to 492cf60 Compare October 20, 2023 15:07

solipet approved these changes Oct 20, 2023

View reviewed changes

soniaconnolly mentioned this pull request Oct 20, 2023

Start using new confirm_start_over_before_letter route #9423

Merged

5 tasks

soniaconnolly merged commit 7edc30b into main Oct 20, 2023

soniaconnolly deleted the abrad-lg-11126-update-idv-start-over branch October 20, 2023 15:28

mdiarra3 mentioned this pull request Oct 23, 2023

Deploy RC 326 to Prod #9432

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-11126 Update Start over verifying your identity screen#9313

LG-11126 Update Start over verifying your identity screen#9313
soniaconnolly merged 19 commits intomainfrom
abrad-lg-11126-update-idv-start-over

theabrad commented Oct 4, 2023 •

edited by soniaconnolly

Loading

Uh oh!

amirbey Oct 5, 2023 •

edited

Loading

Uh oh!

theabrad Oct 10, 2023

Uh oh!

amirbey commented Oct 5, 2023 •

edited

Loading

Uh oh!

soniaconnolly left a comment •

edited

Loading

Uh oh!

solipet left a comment

Uh oh!

solipet left a comment

Uh oh!

Uh oh!

matthinz Oct 19, 2023 •

edited

Loading

Uh oh!

soniaconnolly Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

theabrad commented Oct 4, 2023 • edited by soniaconnolly Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Uh oh!

amirbey Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

theabrad Oct 10, 2023

Choose a reason for hiding this comment

Uh oh!

amirbey commented Oct 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soniaconnolly left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

solipet left a comment

Choose a reason for hiding this comment

Uh oh!

solipet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

matthinz Oct 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

soniaconnolly Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

theabrad commented Oct 4, 2023 •

edited by soniaconnolly

Loading

amirbey Oct 5, 2023 •

edited

Loading

amirbey commented Oct 5, 2023 •

edited

Loading

soniaconnolly left a comment •

edited

Loading

matthinz Oct 19, 2023 •

edited

Loading