-
Notifications
You must be signed in to change notification settings - Fork 166
LG-11126 Update Start over verifying your identity screen #9313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
49471b6
change text for start over verify screen
theabrad 4540ba6
add translations for page
theabrad 6fdc740
add changelog
theabrad 5429f9a
remove unused i18n
theabrad d8dd952
create new translation with question mark added
theabrad 8aca6b2
Merge branch 'main' of github.com:18F/identity-idp into abrad-lg-1112…
theabrad c2c9aaf
Merge branch 'main' of github.com:18F/identity-idp into abrad-lg-1112…
theabrad c330a57
current step indicator for user not in gpo flow yet
theabrad 6e52ef1
a missing period
solipet f8b463a
Restore deleted translations, and rename start_over to start_over_new…
soniaconnolly 57c1d7e
New template for confirm start over from request_letter
soniaconnolly 140e798
Update specs to check for correct template
soniaconnolly 39d9724
Add before_letter route for new screen, don't use it yet
soniaconnolly b7c5ee4
Lint, unused arg in analytics_events
soniaconnolly c10217f
Merge remote-tracking branch 'origin/main' into abrad-lg-11126-update…
soniaconnolly 150335a
alphabetization lint
soniaconnolly 20a6186
Add suggested comment
soniaconnolly 138977b
Merge remote-tracking branch 'origin/main' into abrad-lg-11126-update…
soniaconnolly 492cf60
lints
solipet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| <%= render( | ||
| 'idv/shared/error', | ||
| type: :warning, | ||
| heading: t('idv.cancel.headings.prompt.start_over'), | ||
| current_step: @step_indicator_step, | ||
| ) do %> | ||
| <p> | ||
| <%= t('idv.cancel.description.gpo.start_over_new_address') %> | ||
| </p> | ||
| <p> | ||
| <%= t('idv.cancel.description.gpo.continue') %> | ||
| </p> | ||
|
|
||
| <div class="margin-y-5"> | ||
| <%= render ButtonComponent.new( | ||
| action: ->(**tag_options, &block) do | ||
| button_to(idv_session_path(step: :gpo_verify), **tag_options, &block) | ||
| end, | ||
| method: :delete, | ||
| big: true, | ||
| wide: true, | ||
| ).with_content(t('idv.buttons.continue_plain')) %> | ||
| </div> | ||
| <% end %> | ||
| <%= render('idv/shared/back', step: 'gpo_verify', fallback_path: idv_verify_by_mail_enter_code_path) %> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a double take at this initially but then saw the note in the description about how this is temporary. This is fine for now, but I don't want any
referer-checking code sitting around long term.Maybe just call it out a little bit (and clarify that we're calling out to
before_letterhere):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followup PR: #9423