LG-11083: Enable USPS Public Endpoint by allthesignals · Pull Request #9355 · 18F/identity-idp

allthesignals · 2023-10-11T15:00:19Z

🎫 Ticket

🛠 Summary of changes

Enables USPS search endpoint. Switches to mock data when usps_mock_fallback flag is enabled.

📜 Testing Plan

To set this up locally:

In IDP, make sure you have USPS credentials set up in your application.yml. Then, set:
usps_mock_fallback: false

Run the IDP locally.

In identity-sites, create a file _config.dev.yml and add these values in it:

show_po_search: true
po_search_address_search_url: http://127.0.0.1:3000/api/address_search
po_search_locations_search_url: http://127.0.0.1:3000/api/usps_locations
skip_idp_translations: false

Run identity sites and visit this.

allthesignals · 2023-10-11T17:25:10Z

spec/controllers/idv/in_person/public/usps_locations_controller_spec.rb

I think I have to require the relevant spec file

Oh, or put them in shared examples 😇

I think you need to add a shared example like the one you have here: https://github.com/18F/identity-idp/pull/9355/files#diff-75163b44a581d7a43f027aa8db08c525173b4d280a566720cde848c1abb0f569R43

I'm not sure if there's an easier way to share that code between these specs?

JackRyan1989 · 2023-10-11T18:46:33Z

spec/controllers/idv/in_person/usps_locations_controller_spec.rb

Is the idea here to move all of these parameters into some bit of code that can be shared between this controller and the smaller controller you created for the Help Center?

That's right

JackRyan1989 · 2023-10-11T18:48:02Z

spec/controllers/idv/in_person/public/usps_locations_controller_spec.rb

Just confirming but we don't want to collect any analytics on the Help Center search, correct>

Actually, I'm not sure. It's not mentioned in the ticket buuuut we should definitely check!

@allthesignals has this been followed up on?

@JackRyan1989 I'll make another ticket to add that. It doesn't come for free with the USPS service. I do wonder if that's something might be baked into the USPS service instead of an afterthought on the controllers? Or a Faraday mixin called "Analyzable" or something...

zachmargolis · 2023-10-13T18:00:48Z

app/controllers/idv/in_person/public/usps_locations_controller.rb

is this being included to use methods, or to shorten the namespace for things like EnrollmentHelper? IMO it's more confusing to use it that way, easier to just use the long names

I agree. Updated.

I wish we could lint against includes like this. They make sense when they're used like mixins for sharing controller hooks (RenderConditionConcern). But when used directly, it's confusing. There are some violations/inconsistencies floating around.

…ce search

JackRyan1989

LGTM!

gina-yamada · 2023-10-18T19:01:00Z

I observe mocks in the Help Center. I observe mocks in idp when running locally.

gina-yamada · 2023-10-18T20:46:25Z

@allthesignals Can you show me how you are getting Help Center dev to use the code in this branch in your testing plan?

allthesignals · 2023-10-19T14:40:09Z

@gina-yamada yeah! make sure you have usps_mock_fallback: false in your application.yml. I'll update the PR text

* LG-11083: Enable USPS Public Endpoint (#9355) * changelog: Internal, In-Person Proofing, Enable public USPS post office search * Use EnrollmentHelper to switch between mock/real thing * Try behaves_like * Revert shared examples for now * Use full name * Update report mailer preview to be more realistic (#9419) **How**: stubs CloudwatchClient changelog: Internal, Reporting, Updates report preview to use live code * Add analytics section to frontend documentation (#9421) * Add analytics section to frontend documentation changelog: Internal, Documentation, Add analytics frontend documentation * link to correct javascript package * LG-11101: Support multiple valid MFA to satisfy authentication request (#9335) changelog: User-Facing Improvements, MFA, Avoid prompting for MFA in some scenarios where a recent MFA satisfies the requirement * LG-11148 | Adds monthly report on total verified users (#9376) changelog: Internal, Reporting, Monthly report now includes total verified users Also incorporates LG-11150 Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> * Remove second MFA prompt exception for strict MFA requirement (#9422) changelog: User-Facing Improvements, MFA Setup, Add second MFA reminder screen for single-MFA accounts when signing in at AAL2 * LG-11126 Update Start over verifying your identity screen (#9313) * change text for start over verify screen * add translations for page * add changelog changelog: User-Facing Improvements, IdV By Mail, update text in start over verifying identity screen * remove unused i18n * create new translation with question mark added * current step indicator for user not in gpo flow yet * a missing period * Restore deleted translations, and rename start_over to start_over_new_address Co-authored-by: Doug Price <douglas.price@gsa.gov> * New template for confirm start over from request_letter Add source param to indicate whether referer is request_letter * Update specs to check for correct template Co-authored-by: Doug Price <douglas.price@gsa.gov> * Add before_letter route for new screen, don't use it yet And analytics * Lint, unused arg in analytics_events * alphabetization lint * Add suggested comment Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> * lints --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> * LG-11198: Update address text (#9420) Update address text changelog: User-Facing Improvements, IdV, Update text for address * LG-10922: Display new headings for Hybrid Handoff page on AB test (#9316) * changelog: User-Facing Improvements, Doc Auth, Display new headings for Hybrid Handoff page on AB test Adds: * Conditional headers depending on which flag is on * Hybrid handoff show view test * Translations * LG-11235: Rename double address verification as ipp_enrollment_in_progress (#9390) * Removed double address verification replaced with ipp_enrollment_in_progress * changelog: Internal, In-person Proofing, change DAV references to reflect reality * Change test description to be closer to what is being changed in the controller * Addressing 50/50 state concerns in proofer and adjudicator * Addressing linter issues * Set missing initial value for dav * Moving arg with default value to end of list * Apply suggestions from code review Adding proper input to job_arguments hash. Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Adding note about existing ticket for work post 50/50 state * Resolving Shannon's comments * Adding back in test for dav, need reader on adjudicator * Adding back in test for dav, need reader on adjudicator --------- Co-authored-by: jack.ryan@gsa.gov <johnaryan@fcoh2j-f4t79kf4.myfiosgateway.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Add --deflate option to data-pull and action-account scripts (#9424) changelog: Internal, Scripts, Add --deflate option to data-pull and action-account scripts --------- Co-authored-by: Matt Gardner <wilburnforce@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: Douglas Price <douglas.price@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> Co-authored-by: jc-gsa <104452882+jc-gsa@users.noreply.github.com> Co-authored-by: Brittany Greaner <35475380+night-jellyfish@users.noreply.github.com> Co-authored-by: Jack Ryan <jackryan@navapbc.com> Co-authored-by: jack.ryan@gsa.gov <johnaryan@fcoh2j-f4t79kf4.myfiosgateway.com>

allthesignals changed the title ~~changelog: Internal, In-Person Proofing, Enable public USPS post offi…~~ LG-11083: Enable USPS Public Endpoint Oct 11, 2023

allthesignals commented Oct 11, 2023

View reviewed changes

JackRyan1989 reviewed Oct 11, 2023

View reviewed changes

allthesignals marked this pull request as ready for review October 13, 2023 17:32

zachmargolis reviewed Oct 13, 2023

View reviewed changes

allthesignals added 5 commits October 18, 2023 11:36

changelog: Internal, In-Person Proofing, Enable public USPS post offi…

22c25c5

…ce search

Use EnrollmentHelper to switch between mock/real thing

be941b6

Try behaves_like

f1fd306

Revert shared examples for now

70dc147

Use full name

c785ad6

allthesignals force-pushed the wmg/11083-enable-usps-public-endpoint branch from 46aa665 to c785ad6 Compare October 18, 2023 15:36

allthesignals requested review from a team, JackRyan1989 and gina-yamada October 18, 2023 16:13

JackRyan1989 approved these changes Oct 18, 2023

View reviewed changes

gina-yamada approved these changes Oct 18, 2023

View reviewed changes

allthesignals merged commit 9c17164 into main Oct 19, 2023

allthesignals deleted the wmg/11083-enable-usps-public-endpoint branch October 19, 2023 17:42

mdiarra3 mentioned this pull request Oct 23, 2023

Deploy RC 326 to Prod #9432

Merged

Conversation

allthesignals commented Oct 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎫 Ticket

🛠 Summary of changes

📜 Testing Plan

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JackRyan1989 left a comment

Choose a reason for hiding this comment

Uh oh!

gina-yamada commented Oct 18, 2023

Uh oh!

gina-yamada commented Oct 18, 2023

Uh oh!

allthesignals commented Oct 19, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

allthesignals commented Oct 11, 2023 •

edited

Loading