Skip to content

Deploy RC 317 to Prod#9265

Merged
solipet merged 11 commits intostages/prodfrom
stages/rc-2023-09-26
Sep 26, 2023
Merged

Deploy RC 317 to Prod#9265
solipet merged 11 commits intostages/prodfrom
stages/rc-2023-09-26

Conversation

@solipet
Copy link
Contributor

@solipet solipet commented Sep 26, 2023

User-Facing Improvements

  • Document Authentication: Checking document issuing country (#9232)
  • MFA Setup: Add second MFA reminder screen for single-MFA accounts (#9263)

Internal

  • Cleanup: Fix removing service providers when the associated integration doesn’t have a partner account (#9243)
  • Document Authentication: Testing mock client change (#9244)
  • Identity Verification: Remove pii_from_doc from flow_session, now replaced with idv_session.pii_from_doc (#9198)
  • In-Person Proofing: Make i18n a peer dep (#9257)
  • Reporting: Add count of users passing fraud review to Identity Verification Report (#9251)
  • Scripts: Update pinpoint support script (#9262)
  • Test Proofing: Add VerificationError to mock proofer (#9250)

Upcoming Features

  • In-person proofing: Create feature flag to use during FSM Residential Address removal (#9253)

Jeremy1026 and others added 11 commits September 21, 2023 14:05
changelog: Internal, Cleanup, Fix removing service providers when the associated integration doesn’t have a partner account
* Use `fraud_review_pending` trait instead in gpo verify form spec

[skip changelog]

* Remove unused enum value in spec factory

* Use existing profile traits in gpo otp verification step spec

* Remove vacuous assignment

This spec passes without the assignment, so it can probably be safely removed

* `Profile.bump_fraud_review_pending_timestamps` is never called; remove

* Assign `fraud_rejection` reason to `threatmetrix_reject`

note: strange if this didn't break anything previously

* Use fraud-related profile traits in gpo otp verification step spec

* Use trait and test fraud pending reason

* Remove redundant association

* Add back association for its own ticket

* Restore fraud_pending_reason assignments where timestamps are not yet set

Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>

* Restore fraud_pending_reason assignments in spec

Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>

---------

Co-authored-by: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
* LG-10983: use mock client to generate http status error response(Acuant).

* LG-10427: fix test, method is inherited now.

* changelog: Internal, Document Authentication, Testing mock client change

* LG-10983: remove unused method.
* Create new flag

* changelog: Upcoming Features, In-person proofing, Create feature flag to use during FSM Residential Address removal

* fix spelling error
* LG-10821: sync with main.

* LG-10821: check country when generate error and update test.

* LG-10821: rebase.

* changelog: User-facing Improvements, Document Authentication, Checking document issuing country

* LG-10821: rebase.

* LG-10821: space.

* LG-10821: refactor a little bit based on comment.

* LG-10821: accidental wrong change during rebase.
…rt (#9251)

* Add count of users passing fraud review to Identity Verification Report

changelog: Internal, Reporting, Add count of users passing fraud review to Identity Verification Report

* Filter for success in query, and add fraud_review_passed to successful IdV count

---------

Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
- Strips trailing footnote digits from country names, fixes build

changelog: Internal, Scripts, Update pinpoint support script
* Add VerificationError to mock proofer

changelog: Internal, Test Proofing, Add VerificationError to mock proofer

* Use case statement to check for special first_name

* Add 'Bad' first_name check to case statement

* Preserve prior order of checks

---------

Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Remove flow_session[:pii_from_doc], now replaced with idv_session.pii_from_doc

changelog: Internal, Identity Verification, Remove pii_from_doc from flow_session, now replaced with idv_session.pii_from_doc

* Remove remote idv flow_session method

* Remove pii_from_doc method and access it in idv_session directly (as suggested by Kimball)

---------

Co-authored-by: Douglas Price <douglas.price@gsa.gov>
changelog: User-Facing Improvements, MFA Setup, Add second MFA reminder screen for single-MFA accounts
@solipet solipet changed the title Stages/rc 2023 09 26 Deploy RC 317 to Prod Sep 26, 2023
Copy link
Contributor

@soniaconnolly soniaconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solipet solipet merged commit 88e806a into stages/prod Sep 26, 2023
@solipet solipet deleted the stages/rc-2023-09-26 branch September 26, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants