Merged
Conversation
- Strips trailing footnote digits from country names, fixes build changelog: Internal, Scripts, Update pinpoint support script
zachmargolis
requested review from
ThatSpaceGuy,
allthesignals and
soniaconnolly
allthesignals
approved these changes
Sep 25, 2023
soniaconnolly
approved these changes
Sep 25, 2023
| str.gsub(/\s{2,}/, ' ').gsub(/\s+$/, '') | ||
| end | ||
|
|
||
| def trim_spaces_digits(str) |
Contributor
There was a problem hiding this comment.
Add a comment explaining why this is here?
Suggested change
| def trim_spaces_digits(str) | |
| # Remove trailing footnote numbers from country names | |
| def trim_spaces_digits(str) |
Contributor
Author
There was a problem hiding this comment.
we have a bunch of trimming code and other footnotes in other columns (and in the specs) so I think it'll be ok without
aduth
approved these changes
Sep 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This footnote for New Zealand appeared and broke our script, so this PR strips trailing footnote digits from country names, fixes build