Merged
Conversation
[skip changelog]
This spec passes without the assignment, so it can probably be safely removed
note: strange if this didn't break anything previously
kbighorse
commented
Sep 20, 2023
kbighorse
commented
Sep 21, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
fraud_pending_reason is used correctly in the existing specs and should not be deleted.
kbighorse
commented
Sep 21, 2023
kbighorse
commented
Sep 21, 2023
… set Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
kbighorse
commented
Sep 21, 2023
Co-Authored-By: Sonia Connolly <2381438+soniaconnolly@users.noreply.github.com>
soniaconnolly
approved these changes
Sep 21, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Paired on updating this. LGTM.
kbighorse
deleted the
LG-10902-Profile-attributes-doc-should-be-updated
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[skip changelog]
🎫 Ticket
LG-10902: Profile attributes doc should be updated
🛠 Summary of changes
This PR contains some cleanup encountered in connection with updating our profile documentation.
📜 Testing Plan
Tests pass