LG-10657 remove pii_from_doc from flow session#9198
Merged
soniaconnolly merged 13 commits intomainfrom Sep 25, 2023
Merged
Conversation
Now that we are not using the Flow State Machine, we can stop using flow_session. This is the last attribute to move out in the remote flow. changelog: Internal, Identity Verification, start moving pii_from_doc to idv_session
…moving-pii-from-doc-to-idv-session
…_from_doc changelog: Internal, Identity Verification, Remove flow_session[:pii_from_doc], now replaced with idv_session.pii_from_doc
…suggested by Kimball)
soniaconnolly
changed the base branch from
main
to
sonia-lg-10657-start-moving-pii-from-doc-to-idv-session
6 tasks
Base automatically changed from
sonia-lg-10657-start-moving-pii-from-doc-to-idv-session
to
main
September 20, 2023 18:20
theabrad
approved these changes
Sep 20, 2023
Contributor
theabrad
left a comment
theabrad
left a comment
There was a problem hiding this comment.
LGTM tested through a service provider using all 3 ways listed and saw that it listed the correct information.
And delete leftover part of spec that checked deleting remote flow_session Co-authored-by: Douglas Price <douglas.price@gsa.gov>
solipet
approved these changes
Sep 20, 2023
Contributor
solipet
left a comment
solipet
left a comment
There was a problem hiding this comment.
Walked through changes with Sonia. We agreed that there should be a follow on PR to remove references to user_session['idv/doc_auth'] in the specs and when clearing the session.
LGTM!
soniaconnolly
changed the title
…-pii-from-doc-from-flow-session
…-pii-from-doc-from-flow-session
soniaconnolly
deleted the
sonia-lg-10657-remove-pii-from-doc-from-flow-session
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10657
🛠 Summary of changes
Followup to #9195, to be merged after that is deployed.
📜 Testing Plan