LG 11140 Break up webauthn selection presenter

[kevinsmaster5]

🎫 Ticket

LG-11140

🛠 Summary of changes

Split up Webauthn & Webauthn Platform presenters into Sign Up and Sign In classes as a follow up to #9211

📜 Testing Plan

Adding Security key and Face or touch unlock MFA should continue to work as expected. Sign in with Security key or Face or touch unlock MFA should continue to work as expected.

[mdiarra3]

LGTM

[aduth]

Looking good. Couple minor comments

[aduth]

I'd suggest reordering these methods so that the constructor is first.

Suggested change

	def method
	:webauthn_platform
	end
	def initialize(user:, configuration: nil)
	@user = user
	@configuration = configuration
	end
	def initialize(user:, configuration: nil)
	@user = user
	@configuration = configuration
	end
	def method
	:webauthn_platform
	end

[kevinsmaster5]

Got that reordered.

[aduth]

I think we can remove checks below to configuration.blank?, since I would expect that the configuration should never be blank in the "Sign in" classes. They should be replaced with false.

[aduth]

I just noticed these as I start work on a related ticket. These methods don't raise, so I think we should revise the expectation description accordingly.

Suggested change

	it 'raises with missing translation' do
	expect(presenter.label).to eq(
	t('two_factor_authentication.two_factor_choice_options.webauthn_platform'),
	)
	end
	end
	describe '#info' do
	it 'raises with missing translation' do
	it 'returns the label text' do
	expect(presenter.label).to eq(
	t('two_factor_authentication.two_factor_choice_options.webauthn_platform'),
	)
	end
	end
	describe '#info' do
	it 'returns the info text' do

[aduth]

I think we lost test coverage here, we still have a SetUpWebauthnSelectionPresenter#render_in method.