Merged
Conversation
The `aws_kms_multi_region_read_enabled` was in place to toggle the changes introduced in #9047. Those changes have been deployed, enabled, and have been running without issue for some time. This commit removes the tooling to toggle the feature since we will be using it going forward. [skip changelog]
* remove troubleshooting component from "add photos of your id/check your images & try again" * update link copy for We could not verify your ID page * display help center link on review images page when doc is not a failedDocType * changelog:User-Facing Improvements, Help Center Updates, update help center links in app * make tests consistent with changes in help center links * add spacing and use getHelpCenterURL * fix spacing to occur before help center link * fix spacing after body paragraph on review issues pg * attempt to use getHelpCenterURL in upload.ts * refactor to display help center link from UnknownError * add tests for TipList and UnknownError * change help center link to open in new tab * update spec to reflect link change
* changelog: Internal, In-Person Proofing, Separate components * Move Into separate component * Lint
* add address and city to validation and update spec * changelog: Bug Fixes, State id form, fix validation for address line 1 and city * check dav for addres1 and city validation * lint fix * disable lint message * update spec * update specs with capture_secondary_id_enabled * initialize capture_secondary_id_enabled and lint fixes * lint fix for state id step * lint fix in_person_helper * remove dav from in person helper and spec * remove dav from step helper and ssn spec * update state id step spec and lint
* Reduce size of Webpack i18n plugin template boilerplate changelog: Internal, Performance, Reduce size of translation JavaScript files * Drop semicolon * Golf: Avoid undefined fallback by changing merge order * Update spec fixtures * can't...stop...golfing
[skip changelog]
* changelog: Internal, Authentication, LG-9821: Clean up unused code * fix padding * remove unneeded fr * remove unneeded text * fix deletion error * remove phones controller
* Remove ssn from flow_session, after deploying PR to add it to idv_session Changelog: Internal, Identity Verification, move ssn to idv_session, part 2 of 2 * VerifyInfo show templates need access to @ssn separately from @pii now * Get ssn from idv_session for verify_info templates * Update IdvStepConcern#confirm_ssn_step_complete * Set @ssn in #show, not in #pii, to fix :confirm_ssn_step_complete before action * Set idv_session.ssn in in_person verify_info_controller_spec * Add ssn back to pii for proof_resolution job in VerifyInfoConcern * Remove specs for ssn in flow_session --------- Co-authored-by: Gina Yamada <gina.yamada@gsa.gov>
* LG-8681: Replace h4 with h2 in emails per VPAT findings changelog: User-Facing Improvements, Accessibility, Use h1 tag for main heading in emails * LG-8681: Use H1 tag per design and content guidance * LG-8681: Update email heading styles to better meet desktop LGDS standards * LG-8681: Format CSS * LG-8681: Minor HTML/ERB formatting cleanup
aduth
requested review from
NavaTim,
allthesignals,
eileen-nava,
gina-yamada,
jmhooper,
soniaconnolly,
svalexander and
zachmargolis
Contributor
Author
|
Misnamed the branch (should end |
NavaTim
approved these changes
Sep 13, 2023
eileen-nava
approved these changes
Sep 13, 2023
mdiarra3
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal