Merged
Conversation
* turning i18n into own package * changelog: Internal, i18n package, turn i18n into its own package * remove extra space * Remove webpack/babel configs and publish as-is * Specify i18n as dep * Revert "Remove webpack/babel configs and publish as-is" This reverts commit 1340b18. * Use correct source path * Revert "Specify i18n as dep" This reverts commit cd9f6e5. * Use @babel/cli to transpile * Use @babel/cli to transpile * Updated version of i18n from beta to 1.0.0 * remove react peer dependency in i18n * moved @babel/cli to a devDep rather than a dep * Update app/javascript/packages/i18n/package.json removed extra unnecessary space Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * ran yarn install to resolve linter error * restore yarn lock to what is on main * restore what is on main * re-ran yarn install to fix linter error * Update babel configuration to fix compilation * bumped version up --------- Co-authored-by: Matt Gardner <wilburnforce@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-10621 | Proofing Rate Report [skip changelog] Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Luis H. Matos <ThatSpaceGuy@users.noreply.github.com>
* Require recent authentication before deleting account changelog: User-Facing Improvements, Account Deletion, Require recent authentication before deleting account * add before_action specs
* Officially turn on new GPO routes Keep redirects in place for old routes to support 50/50 state [skip changelog] * Fix presenter spec * Break out Idv::ByMail into nested namespace * Don't hardcode paths in RequestLetterPresenter spec
* Add IDV rejects to report * Update failure states to use sets * Update proofing rate report to add Industry Rate * Add filtering for "doc_auth_failed_non_fraud" changelog: Internal, Reporting, Update proofing rate report Co-authored-by: Luis <lmatos@flexion.us>
- Runs queries for each 30d batch in parallel, combines them after changelog: Internal, Reporting, Update proofing rate report
…ler (#8950) * Try replacing NewRelic browser instrumentation with custom error handler changelog: Internal, Error Tracking, Implement replacement frontend error logger * Experiment with hand-minified inline snippet * Must go smaller * Smaller! * Filter events to same-host script errors * Use javascript_tag for prelude script Previously trying to avoid CDATA , but more standard * Log Webpack script errors in development environment * Route frontend error events to NewRelic * Revert "Log Webpack script errors in development environment" This reverts commit bafdea8. * Remove demo error * Update index.spec.ts * Add custom proc support to FrontendLogger, simplify FrontendLogController error reporting * Bring back parens around assignment inside a conditional * Use #public_send on method name so that AnalyticsEventEnhancer can do its thing - bind_call calls a specific method implementation, so it doesn't go through the Enhancer implementation * dedicated class? * WIP: experimenting with less special-casing of Analytics class * Revert "WIP: experimenting with less special-casing of Analytics class" This reverts commit ae086b4. * Slight simplification, support #call-able objects * Rename and document things for clarity * Lint is_a * Fix issue with IdV::AnalyticsEventsEnhancer override The method signature is lost if read directly from analytics instance, since it's overridden by AnalyticsEventsEnhancer. We need the original method reference * Log errors as expected * Temporary: Test error * Alphabetize analytics events * Update spec expectations * Revert "Temporary: Test error" This reverts commit 13d961e. * Try namespacing logged error Easier to see grouped in alphabetical order, avoid conflicting names --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
changelog: Internal, Error Tracking, Implement replacement frontend error logger
changelog: Internal, Dependencies, Upgrade NewRelic gem
* Add logging to debug ssn 50/50 state issue. [skip changelog] * Set pii[:ssn] before calling proof_resolution job. This needs to go out on its own before the pii_from_doc[:ssn] delete PR because it needs to already exist in old instances during the 50/50 state when the new instances only write the ssn to idv_session.ssn. --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
#9206) * LG-11014: Log created at for latest WebAuthn config for failed attempt changelog: Internal, Logging, Log latest WebAuthn creation date for failed attempt * Fix logic for form webauthn configuration * Use last over take Guarantee order of ascending creation date TODO: Test coverage * Sort descending to get latest * First, not last
changelog: Internal, Performance, Reduce size of JavaScript bundles
changelog: Internal, Performance, Reduce size of JavaScript bundles
LG-10682 A user can only enqueue 1 GPO letter per day Modified GpoMail#spammed? to also return true if the user has already enqueued a letter today. - New config setting `minimum_wait_before_another_usps_letter_in_hours` to control this new rule. Setting this value to 0 disables the new rule. The default value is 24. - Per conversation with Hooper, re-did internal logic to be based on `GpoConfirmationCode` rather than `Event` . This is necessary because the new rate limiting rule applies on a per-profile basis, but user's events don't retain this information. (Also, `GpoConfirmationCode` did not exist when this logic was originally implemented. Now that it does, this is a better implementation.) - Per review comments from Sonia and Mitchell, removed constants from `GpoMail` and just used the config values (the constants were initialized from config values). - Updated feature specs in `enter_code_controller_spec.rb` and `ial2_sso_spec.rb` which were rendered incorrect by the new rule - Added extra checks inline in `gpo_step_spec.rb` to verify the new rule. Inlined the spec for the original rule, too. --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
… limiter (#9222) changelog: Internal, Testing, Fix identity verification session error tests to use the correct rate limiter
changelog: Internal, Rate Limiting, Do not consider a rate limit expired if there is no value
Contributor
aduth
approved these changes
Sep 18, 2023
[skip changelog]
mitchellhenke
force-pushed
the
stages/rc-2023-09-18
branch
from
2d7cfb1 to
fe6632c
Compare
* Revert "Revert "LG-10886 remove ssn from flow session (#9182)" (#9209)" Fixed 50/50 state issue by adding :ssn to pii going to proof resolution job in deploy 314.2. This reverts commit 4f0ad04. * Don't use ||= when adding ssn to pii for proof resolution job If someone updates their SSN, we want it to be updated for the proofing job, so use =
mitchellhenke
force-pushed
the
stages/rc-2023-09-18
branch
from
fe6632c to
7d82009
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Internal