Set Remember Device Expiration for AAL2 to 0 hours#8926
Merged
mitchellhenke merged 10 commits intomainfrom Aug 4, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/change-remember-device-expiration-hours-aal-2-to-zero
branch
from
1eeebc1 to
711e3bb
Compare
aduth
approved these changes
Aug 3, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
LGTM 👍
Will we plan to remove the overrides for the environments where it's already set to this value?
Contributor
Author
Yep! |
mitchellhenke
force-pushed
the
mitchellhenke/change-remember-device-expiration-hours-aal-2-to-zero
branch
3 times, most recently
from
b2461b8 to
297f546
Compare
added 10 commits
August 4, 2023 11:41
changelog: Internal, Configuration, Set Remember Device Expiration for AAL2 to 0 hours
mitchellhenke
force-pushed
the
mitchellhenke/change-remember-device-expiration-hours-aal-2-to-zero
branch
from
088ca23 to
621ef9d
Compare
mitchellhenke
deleted the
mitchellhenke/change-remember-device-expiration-hours-aal-2-to-zero
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This change was made across our live environments a few months ago (thread), but I never followed up to make it consistent everywhere. This PR changes the default to zero.
[EDIT]
There was quite a bit of testing that assumed different behaviors of AAL2/remembered device, so this PR also applies some changes to hopefully make those easier to maintain going forward. Test coverage difference between this PR and main does not show a reduction (in line or branch-based), which isn't conclusive that we haven't lost certain permutations of some behavior being tested, but is sufficient for me to move forward with the changes.