Skip to content

Switch AAL2 remembered device expiration configuration units from hours to minutes #9000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitchellhenke merged 1 commit into from
Aug 14, 2023
Merged

Switch AAL2 remembered device expiration configuration units from hours to minutes #9000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/decorators/service_provider_session_decorator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ def sp_alert(section)

def mfa_expiration_interval
aal_1_expiration = IdentityConfig.store.remember_device_expiration_hours_aal_1.hours
aal_2_expiration = IdentityConfig.store.remember_device_expiration_hours_aal_2.hours
aal_2_expiration = IdentityConfig.store.remember_device_expiration_minutes_aal_2.minutes
return aal_2_expiration if sp_aal > 1
return aal_2_expiration if sp_ial > 1
return aal_2_expiration if requested_aal > 1
Expand Down
2 changes: 1 addition & 1 deletion config/application.yml.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ reg_unconfirmed_email_max_attempts: 20
reg_unconfirmed_email_window_in_minutes: 60
reject_id_token_hint_in_logout: false
remember_device_expiration_hours_aal_1: 720
remember_device_expiration_hours_aal_2: 0
remember_device_expiration_minutes_aal_2: 0
report_timeout: 0
requests_per_ip_cidr_allowlist: ''
requests_per_ip_limit: 300
Expand Down
2 changes: 1 addition & 1 deletion lib/identity_config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ def self.build_store(config_map)
config.add(:reg_unconfirmed_email_window_in_minutes, type: :integer)
config.add(:reject_id_token_hint_in_logout, type: :boolean)
config.add(:remember_device_expiration_hours_aal_1, type: :integer)
config.add(:remember_device_expiration_hours_aal_2, type: :integer)
config.add(:remember_device_expiration_minutes_aal_2, type: :integer)
config.add(:report_timeout, type: :integer)
config.add(:requests_per_ip_cidr_allowlist, type: :comma_separated_string_list)
config.add(:requests_per_ip_limit, type: :integer)
Expand Down
2 changes: 1 addition & 1 deletion spec/features/remember_device/sp_expiration_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def visit_sp(protocol, aal)
AAL1_REMEMBER_DEVICE_EXPIRATION =
IdentityConfig.store.remember_device_expiration_hours_aal_1.hours
AAL2_REMEMBER_DEVICE_EXPIRATION =
IdentityConfig.store.remember_device_expiration_hours_aal_2.hours
IdentityConfig.store.remember_device_expiration_minutes_aal_2.minutes

let(:user) do
user_record = sign_up_and_set_password
Expand Down