Hardcode chromedriver version until we get an upgrade that works#8942
Hardcode chromedriver version until we get an upgrade that works#8942soniaconnolly merged 3 commits intomainfrom
Conversation
Chromedriver versions are behind Chrome, so we need to hardcode the version until Chromedriver catches up. [skip changelog]
We probably could (should even?). I can't recall if that's as easy as just getting a "fresh" CI image SHA from devops (e.g. bottom of the build log here) to use in config, or if it needs something else. Alternatively, we could maybe isolate it to local development, either using the require 'webdrivers'
begin
Webdrivers::Chromedriver.latest_version
rescue Webdrivers::VersionError
Webdrivers::Chromedriver.required_version = '114.0.5735.90'
end |
CI is using an older version and there were issues when we tried to upgrade.
d2e9142 to
e0d9274
Compare
That works much better, thanks! I thought about that too after walking away from the computer on Friday. |
spec/rails_helper.rb
Outdated
| # temporary fix for local development feature tests | ||
| # remove when we get a new working version of Chromedriver | ||
| if ENV['CI'] != 'true' | ||
| Webdrivers::Chromedriver.required_version = '114.0.5735.90' |
There was a problem hiding this comment.
I might expect to see this configuration someplace like support/capybara.rb, but not a big deal if it's short-lived.
There was a problem hiding this comment.
Good idea. That works too. No need to reset it before each spec.
timothy-spencer
left a comment
There was a problem hiding this comment.
If this gets you going, LGTM! Longer term, we should move the IDP CI build over here so that you have direct control over it and don't need to hack in stuff like this.
Chromedriver versions are behind Chrome, so we need to hardcode the version until Chromedriver catches up.
This is affecting more and more devs who want to run feature specs, and it's a hassle to keep an edited rails_helper.rb around without committing it. We can revert this when we get a version of Chromedriver that works.
ETA: Looks like we need to upgrade the version of Chrome that CI uses to make this work. Is that an option?