Do not auto-submit forms if they have multiple inputs#2696
Merged
twalpole merged 1 commit intoteamcapybara:masterfrom Aug 10, 2023
Merged
Conversation
Member
|
This is how it was supposed to be in the first place - thanks for catching |
Author
|
Thank you so much! |
lukaszmakuch
pushed a commit
to lukaszmakuch/capybara
that referenced
this pull request
Aug 26, 2023
lukaszmakuch
pushed a commit
to lukaszmakuch/capybara
that referenced
this pull request
Aug 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for capybara!
I am attempting to update to the latest version, but am having some test failures from the change in 6b05e5c as I have forms where I set multiple inputs in the same form to values that end with
\n.I think ideally I'd be able to opt-out of the auto-submit behavior, but I'm unsure what the preferred path is. I'm happy to make updates to the branch here as well. Thanks again for all the work that goes into capybara!