Remove add_cost and add_costs method from Idv::Steps::DocAuthBaseStep#10448
Merged
Remove add_cost and add_costs method from Idv::Steps::DocAuthBaseStep#10448
add_cost and add_costs method from Idv::Steps::DocAuthBaseStep#10448Conversation
…eStep` The `add_cost` and `add_costs` methods both create `SpCost` records for FlowStateMachine steps the inherit from `Idv::Steps::DocAuthBaseStep`. We [removed the `FlowStateMachine`](#8705) from all paths that lead to the creation of an `SpCost` record about a year ago. The [`FlowStateMachine`](https://github.com/18F/identity-idp/blob/main/app/services/flow/flow_state_machine.rb) and associated [`Idv::Steps::DocAuthBaseStep`](https://github.com/18F/identity-idp/blob/main/app/services/idv/steps/doc_auth_base_step.rb) remain, however, to support the in-person flow. The in-person flow does not create `SpCost` records in the `FlowStateMachine`. These methods, like many methods in `FlowStateMachine` relics are unused. We left these unused methods because it was assumed that the `FlowStateMachine` would be removed from the in-person flow shortly after it was removed from the unsupervised flow. That has not been the case so this commit does some cleanup to remove them. [skip changelog]
jmhooper
changed the title
add_cost and add_costs method from `Idv::Steps::DocAuthBaseStepadd_cost and add_costs method from Idv::Steps::DocAuthBaseStep
matthinz
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
add_costandadd_costsmethods both createSpCostrecords forFlowStateMachinesteps that inherit fromIdv::Steps::DocAuthBaseStep.We removed the
FlowStateMachinefrom all paths that lead to the creation of anSpCostrecord about a year ago. TheFlowStateMachineand associatedIdv::Steps::DocAuthBaseStepremain, however, to support the in-person flow. The in-person flow does not createSpCostrecords in theFlowStateMachine.These methods, like many methods in
FlowStateMachinerelics, are unused. We left these unused methods because it was assumed that theFlowStateMachinewould be entirely removed from the in-person flow shortly after it was removed from the unsupervised flow. That has not been the case so this commit does some cleanup to remove them.