Refactor telephony.log logging to use common interface to enable including metadata in logs#8765
Merged
mitchellhenke merged 2 commits intomainfrom Jul 12, 2023
Merged
Conversation
…uding metadata changelog: Internal, Logging, Refactor telephony.log logging to use common interface to enable including metadata
zachmargolis
approved these changes
Jul 12, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
A small followup to #8610 to add
log_filenameto the Telephony logger. This one was a bit more involved than the ones in #8610 since previously calls were being made directly toTelephony.config.logger. This PR refactors the logging to put it behind a method so that we can add the metadata to all logging calls.