Update review application configuration to behave closer to development environment#8671
Merged
mitchellhenke merged 2 commits intomainfrom Jun 28, 2023
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/update-review-app-config
branch
from
7547531 to
101a186
Compare
timothy-spencer
approved these changes
Jun 27, 2023
Contributor
timothy-spencer
left a comment
timothy-spencer
left a comment
There was a problem hiding this comment.
If that works for you, it works for me. :-)
mitchellhenke
force-pushed
the
mitchellhenke/update-review-app-config
branch
2 times, most recently
from
2dc9c0c to
94b9ed3
Compare
jmhooper
approved these changes
Jun 28, 2023
mitchellhenke
force-pushed
the
mitchellhenke/update-review-app-config
branch
2 times, most recently
from
52d9e1d to
63e2cb0
Compare
added 2 commits
June 28, 2023 13:01
…ot require an SP to proof, and log to STDOUT changelog: Internal, Continuous Integration, Update review application configuration to do synchronous proofing, not require an SP to proof, and log to STDOUT
mitchellhenke
force-pushed
the
mitchellhenke/update-review-app-config
branch
from
63e2cb0 to
5c60bc6
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Following today's appdev/devops sync, this brings a few changes to make review apps to be a bit more useful for reviewing changes by making identity proofing possible. It also changes the logs to go to STDOUT (related to #8610)