Reduce RedoDocumentCaptureSpec flakiness#8656
Closed
soniaconnolly wants to merge 1 commit intomainfrom
Closed
Conversation
Repeat initial DocumentCapture once if it doesn't move forward to SSN page. [skip changelog]
Contributor
|
Would the repeat behavior be something we could expect happens for real users? |
Contributor
Author
That is an excellent question. The tests weren't flaky before, but the flakiness started around the time the RedoDocumentCaptureAction was deleted, and we added a bug fix around it. @matthinz says it happens around 1/100 test runs. I don't think a lot of users get the barcode read error, continue to VerifyInfo, and then click the Redo link. |
Contributor
Author
|
Mitchell put in a PR to just skip these tests instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeat initial DocumentCapture once if it doesn't move forward to SSN page.
It is unclear why these specs are occasionally getting stuck on the DocumentCapture page when they should move forward to SSN page. While research continues, try repeating the DocumentCapture attach_and_submit images to reduce flakiness.