Remove RedoDocumentCaptureAction and CancelLinkSentAction#8600
Merged
soniaconnolly merged 1 commit intomainfrom Jun 15, 2023
Merged
Remove RedoDocumentCaptureAction and CancelLinkSentAction#8600soniaconnolly merged 1 commit intomainfrom
soniaconnolly merged 1 commit intomainfrom
Conversation
Now that HybridHandoff is outside the FSM, we are using redirects rather than FSM actions to go back to that step. Feature specs have been moved, not deleted. changelog: Internal, Refactor, Remove unused doc_auth flow state machine actions
eric-gade
reviewed
Jun 15, 2023
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
Aside from one inline, code looks good to me. I'm having some trouble testing manually so I've messaged you about it separately on slack
| track_event('IdV: doc auth agreement visited', **extra) | ||
| end | ||
|
|
||
| def idv_doc_auth_cancel_link_sent_submitted(**extra) |
Contributor
There was a problem hiding this comment.
Are these analytics events re-implemented elsewhere or are they not relevant anymore?
Contributor
Author
There was a problem hiding this comment.
They were only used by the actions being deleted, and have been replaced in #8581 with additional params for hybrid_handoff_visited and document_capture_visited.
eric-gade
approved these changes
Jun 15, 2023
Contributor
eric-gade
left a comment
eric-gade
left a comment
There was a problem hiding this comment.
Update: the testing worked for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-10075
🛠 Summary of changes
Now that HybridHandoff is outside the FSM, we are using redirects rather than FSM actions to go back to that step, so RedoDocumentCaptureAction and CancelLinkSentAction can be deleted. This is a followup to PRs #8557 and #8581.
Feature specs have been moved, not deleted.
📜 Testing Plan